* [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
@ 2017-08-20 9:19 Julia Lawall
2017-08-20 16:28 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2017-08-20 9:19 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, Dmitry Torokhov, linux-input, linux-kernel,
kbuild-all
No need to set .owner here. The core will do it.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
dc_ti_pwrbtn.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/input/keyboard/dc_ti_pwrbtn.c
+++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
@@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
static struct platform_driver dc_ti_pwrbtn_driver = {
.driver = {
.name = DRIVER_NAME,
- .owner = THIS_MODULE,
},
.probe = dc_ti_pwrbtn_probe,
};
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
2017-08-20 9:19 [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Julia Lawall
@ 2017-08-20 16:28 ` Dmitry Torokhov
2017-08-20 16:44 ` Julia Lawall
2017-08-20 20:35 ` Takashi Iwai
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2017-08-20 16:28 UTC (permalink / raw)
To: Julia Lawall
Cc: Takashi Iwai, alsa-devel, linux-input, linux-kernel, kbuild-all
On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> dc_ti_pwrbtn.c | 1 -
Hm, this driver is neither in my tree nor in next; where is it coming
from?
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> static struct platform_driver dc_ti_pwrbtn_driver = {
> .driver = {
> .name = DRIVER_NAME,
> - .owner = THIS_MODULE,
> },
> .probe = dc_ti_pwrbtn_probe,
> };
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
2017-08-20 16:28 ` Dmitry Torokhov
@ 2017-08-20 16:44 ` Julia Lawall
2017-08-20 20:35 ` Takashi Iwai
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-08-20 16:44 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Julia Lawall, Takashi Iwai, alsa-devel, linux-input, linux-kernel,
kbuild-all
On Sun, 20 Aug 2017, Dmitry Torokhov wrote:
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > dc_ti_pwrbtn.c | 1 -
>
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?
Sorry, it's a kbuild message and I seem to have deleted the message with
that information...
julia
>
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> > static struct platform_driver dc_ti_pwrbtn_driver = {
> > .driver = {
> > .name = DRIVER_NAME,
> > - .owner = THIS_MODULE,
> > },
> > .probe = dc_ti_pwrbtn_probe,
> > };
>
> --
> Dmitry
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
2017-08-20 16:28 ` Dmitry Torokhov
2017-08-20 16:44 ` Julia Lawall
@ 2017-08-20 20:35 ` Takashi Iwai
1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2017-08-20 20:35 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Julia Lawall, alsa-devel, linux-input, linux-kernel, kbuild-all
On Sun, 20 Aug 2017 18:28:41 +0200,
Dmitry Torokhov wrote:
>
> On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> > No need to set .owner here. The core will do it.
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > dc_ti_pwrbtn.c | 1 -
>
> Hm, this driver is neither in my tree nor in next; where is it coming
> from?
It's only in my tree for testing, but kbuild bot takes all branches
unconditionally, so...
In anyway, I hope I can submit sooner or later :)
Takashi
>
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
> > static struct platform_driver dc_ti_pwrbtn_driver = {
> > .driver = {
> > .name = DRIVER_NAME,
> > - .owner = THIS_MODULE,
> > },
> > .probe = dc_ti_pwrbtn_probe,
> > };
>
> --
> Dmitry
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-20 20:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 9:19 [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Julia Lawall
2017-08-20 16:28 ` Dmitry Torokhov
2017-08-20 16:44 ` Julia Lawall
2017-08-20 20:35 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).