From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365
Date: Sun, 20 Aug 2017 09:29:19 -0700 [thread overview]
Message-ID: <20170820162919.GB1176@dtor-ws> (raw)
In-Reply-To: <20170820094221.7629-1-hdegoede@redhat.com>
On Sun, Aug 20, 2017 at 11:42:21AM +0200, Hans de Goede wrote:
> The Dell XPS13 9365 has an INT33D2 ACPI node with no GPIOs, causing
> the following error in dmesg:
>
> [ 7.172275] soc_button_array: probe of INT33D2:00 failed with error -2
>
> This commit silences this, by returning -ENODEV when there are no GPIOs.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196679
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
> ---
> drivers/input/misc/soc_button_array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index 27b99831cb97..0f7cce70f748 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -334,7 +334,7 @@ static int soc_button_probe(struct platform_device *pdev)
> error = gpiod_count(dev, NULL);
> if (error < 0) {
> dev_dbg(dev, "no GPIO attached, ignoring...\n");
> - return error;
> + return -ENODEV;
> }
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> --
> 2.13.4
>
--
Dmitry
prev parent reply other threads:[~2017-08-20 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 9:42 [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365 Hans de Goede
2017-08-20 16:29 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170820162919.GB1176@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).