* [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365
@ 2017-08-20 9:42 Hans de Goede
2017-08-20 16:29 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2017-08-20 9:42 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Hans de Goede, linux-input
The Dell XPS13 9365 has an INT33D2 ACPI node with no GPIOs, causing
the following error in dmesg:
[ 7.172275] soc_button_array: probe of INT33D2:00 failed with error -2
This commit silences this, by returning -ENODEV when there are no GPIOs.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196679
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/input/misc/soc_button_array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index 27b99831cb97..0f7cce70f748 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -334,7 +334,7 @@ static int soc_button_probe(struct platform_device *pdev)
error = gpiod_count(dev, NULL);
if (error < 0) {
dev_dbg(dev, "no GPIO attached, ignoring...\n");
- return error;
+ return -ENODEV;
}
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
--
2.13.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365
2017-08-20 9:42 [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365 Hans de Goede
@ 2017-08-20 16:29 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-08-20 16:29 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-input
On Sun, Aug 20, 2017 at 11:42:21AM +0200, Hans de Goede wrote:
> The Dell XPS13 9365 has an INT33D2 ACPI node with no GPIOs, causing
> the following error in dmesg:
>
> [ 7.172275] soc_button_array: probe of INT33D2:00 failed with error -2
>
> This commit silences this, by returning -ENODEV when there are no GPIOs.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196679
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
> ---
> drivers/input/misc/soc_button_array.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index 27b99831cb97..0f7cce70f748 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -334,7 +334,7 @@ static int soc_button_probe(struct platform_device *pdev)
> error = gpiod_count(dev, NULL);
> if (error < 0) {
> dev_dbg(dev, "no GPIO attached, ignoring...\n");
> - return error;
> + return -ENODEV;
> }
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> --
> 2.13.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-20 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 9:42 [PATCH] Input: soc_button_array - Silence -ENOENT error on Dell XPS13 9365 Hans de Goede
2017-08-20 16:29 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).