* [PATCH] HID: multitouch: Fix system-control buttons not working
@ 2017-08-22 6:37 Hans de Goede
2017-08-22 8:59 ` Benjamin Tissoires
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Hans de Goede @ 2017-08-22 6:37 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: Hans de Goede, linux-input
Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
interface as a hid-multitouch touch-pad.
This commit fixes these buttons not working.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/hid/hid-multitouch.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 0a8689bb08e9..53d1413cd435 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
field->application != HID_DG_PEN &&
field->application != HID_DG_TOUCHPAD &&
field->application != HID_GD_KEYBOARD &&
+ field->application != HID_GD_SYSTEM_CONTROL &&
field->application != HID_CP_CONSUMER_CONTROL &&
field->application != HID_GD_WIRELESS_RADIO_CTLS &&
!(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
--
2.13.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-08-22 6:37 [PATCH] HID: multitouch: Fix system-control buttons not working Hans de Goede
@ 2017-08-22 8:59 ` Benjamin Tissoires
2017-08-22 10:08 ` Hans de Goede
2017-08-31 15:35 ` Hans de Goede
2017-09-06 8:54 ` Jiri Kosina
2 siblings, 1 reply; 7+ messages in thread
From: Benjamin Tissoires @ 2017-08-22 8:59 UTC (permalink / raw)
To: Hans de Goede; +Cc: Jiri Kosina, linux-input
On Aug 22 2017 or thereabouts, Hans de Goede wrote:
> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
> interface as a hid-multitouch touch-pad.
>
> This commit fixes these buttons not working.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 0a8689bb08e9..53d1413cd435 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> field->application != HID_DG_PEN &&
> field->application != HID_DG_TOUCHPAD &&
> field->application != HID_GD_KEYBOARD &&
> + field->application != HID_GD_SYSTEM_CONTROL &&
> field->application != HID_CP_CONSUMER_CONTROL &&
> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
> --
> 2.13.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-08-22 8:59 ` Benjamin Tissoires
@ 2017-08-22 10:08 ` Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2017-08-22 10:08 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Jiri Kosina, linux-input
Hi,
On 22-08-17 10:59, Benjamin Tissoires wrote:
> On Aug 22 2017 or thereabouts, Hans de Goede wrote:
>> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
>> interface as a hid-multitouch touch-pad.
>>
>> This commit fixes these buttons not working.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks.
Note this applies on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/log/?h=for-4.14/multitouch
(in case that was not clear)
Regards,
Hans
>
>> drivers/hid/hid-multitouch.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 0a8689bb08e9..53d1413cd435 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>> field->application != HID_DG_PEN &&
>> field->application != HID_DG_TOUCHPAD &&
>> field->application != HID_GD_KEYBOARD &&
>> + field->application != HID_GD_SYSTEM_CONTROL &&
>> field->application != HID_CP_CONSUMER_CONTROL &&
>> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
>> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
>> --
>> 2.13.4
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-08-22 6:37 [PATCH] HID: multitouch: Fix system-control buttons not working Hans de Goede
2017-08-22 8:59 ` Benjamin Tissoires
@ 2017-08-31 15:35 ` Hans de Goede
2017-09-05 9:42 ` Jiri Kosina
2017-09-06 8:54 ` Jiri Kosina
2 siblings, 1 reply; 7+ messages in thread
From: Hans de Goede @ 2017-08-31 15:35 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-input
Hi,
On 22-08-17 08:37, Hans de Goede wrote:
> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
> interface as a hid-multitouch touch-pad.
>
> This commit fixes these buttons not working.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
What is the status of this patch ? It would be nice to get this
bug-fix into 4.14.
Regards,
Hans
> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 0a8689bb08e9..53d1413cd435 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> field->application != HID_DG_PEN &&
> field->application != HID_DG_TOUCHPAD &&
> field->application != HID_GD_KEYBOARD &&
> + field->application != HID_GD_SYSTEM_CONTROL &&
> field->application != HID_CP_CONSUMER_CONTROL &&
> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-08-31 15:35 ` Hans de Goede
@ 2017-09-05 9:42 ` Jiri Kosina
2017-09-05 10:04 ` Hans de Goede
0 siblings, 1 reply; 7+ messages in thread
From: Jiri Kosina @ 2017-09-05 9:42 UTC (permalink / raw)
To: Hans de Goede; +Cc: Benjamin Tissoires, linux-input
On Thu, 31 Aug 2017, Hans de Goede wrote:
> > Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
> > interface as a hid-multitouch touch-pad.
> >
> > This commit fixes these buttons not working.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> What is the status of this patch ? It would be nice to get this
> bug-fix into 4.14.
I have been on vacation for past 14 days. I'll process this patch in the
second wave once current merge window pull request is processed, and will
be applied still as 4.14 bugfix.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-09-05 9:42 ` Jiri Kosina
@ 2017-09-05 10:04 ` Hans de Goede
0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2017-09-05 10:04 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input
Hi,
On 05-09-17 11:42, Jiri Kosina wrote:
> On Thu, 31 Aug 2017, Hans de Goede wrote:
>
>>> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
>>> interface as a hid-multitouch touch-pad.
>>>
>>> This commit fixes these buttons not working.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> What is the status of this patch ? It would be nice to get this
>> bug-fix into 4.14.
>
> I have been on vacation for past 14 days. I'll process this patch in the
> second wave once current merge window pull request is processed, and will
> be applied still as 4.14 bugfix.
Great, thank you.
Regards,
Hans
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] HID: multitouch: Fix system-control buttons not working
2017-08-22 6:37 [PATCH] HID: multitouch: Fix system-control buttons not working Hans de Goede
2017-08-22 8:59 ` Benjamin Tissoires
2017-08-31 15:35 ` Hans de Goede
@ 2017-09-06 8:54 ` Jiri Kosina
2 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2017-09-06 8:54 UTC (permalink / raw)
To: Hans de Goede; +Cc: Benjamin Tissoires, linux-input
On Tue, 22 Aug 2017, Hans de Goede wrote:
> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
> interface as a hid-multitouch touch-pad.
>
> This commit fixes these buttons not working.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to for-4.14/upstream-fixes.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-06 8:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-22 6:37 [PATCH] HID: multitouch: Fix system-control buttons not working Hans de Goede
2017-08-22 8:59 ` Benjamin Tissoires
2017-08-22 10:08 ` Hans de Goede
2017-08-31 15:35 ` Hans de Goede
2017-09-05 9:42 ` Jiri Kosina
2017-09-05 10:04 ` Hans de Goede
2017-09-06 8:54 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).