* [PATCH] hid: Fix system-control buttons on a multitouch interface not working
@ 2017-08-17 10:48 Hans de Goede
2017-08-22 9:00 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2017-08-17 10:48 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: Hans de Goede, linux-input
Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
interface as a hid-multitouch touch-pad.
This commit fixes these buttons not working.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/hid/hid-multitouch.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 0a8689bb08e9..53d1413cd435 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
field->application != HID_DG_PEN &&
field->application != HID_DG_TOUCHPAD &&
field->application != HID_GD_KEYBOARD &&
+ field->application != HID_GD_SYSTEM_CONTROL &&
field->application != HID_CP_CONSUMER_CONTROL &&
field->application != HID_GD_WIRELESS_RADIO_CTLS &&
!(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
--
2.13.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: Fix system-control buttons on a multitouch interface not working
2017-08-17 10:48 [PATCH] hid: Fix system-control buttons on a multitouch interface not working Hans de Goede
@ 2017-08-22 9:00 ` Benjamin Tissoires
2017-08-22 10:06 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2017-08-22 9:00 UTC (permalink / raw)
To: Hans de Goede; +Cc: Jiri Kosina, linux-input
On Aug 17 2017 or thereabouts, Hans de Goede wrote:
> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
> interface as a hid-multitouch touch-pad.
>
> This commit fixes these buttons not working.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 0a8689bb08e9..53d1413cd435 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> field->application != HID_DG_PEN &&
> field->application != HID_DG_TOUCHPAD &&
> field->application != HID_GD_KEYBOARD &&
> + field->application != HID_GD_SYSTEM_CONTROL &&
> field->application != HID_CP_CONSUMER_CONTROL &&
> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
> --
> 2.13.4
Looks like you resent it this morning as https://patchwork.kernel.org/patch/9914313/
We can discard this one then I guess.
Cheers,
Benjamin
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hid: Fix system-control buttons on a multitouch interface not working
2017-08-22 9:00 ` Benjamin Tissoires
@ 2017-08-22 10:06 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2017-08-22 10:06 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Jiri Kosina, linux-input
Hi,
On 22-08-17 11:00, Benjamin Tissoires wrote:
> On Aug 17 2017 or thereabouts, Hans de Goede wrote:
>> Some laptops have system-control buttons (e.g. KEY_SLEEP) on the same
>> interface as a hid-multitouch touch-pad.
>>
>> This commit fixes these buttons not working.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/hid/hid-multitouch.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 0a8689bb08e9..53d1413cd435 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -930,6 +930,7 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>> field->application != HID_DG_PEN &&
>> field->application != HID_DG_TOUCHPAD &&
>> field->application != HID_GD_KEYBOARD &&
>> + field->application != HID_GD_SYSTEM_CONTROL &&
>> field->application != HID_CP_CONSUMER_CONTROL &&
>> field->application != HID_GD_WIRELESS_RADIO_CTLS &&
>> !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
>> --
>> 2.13.4
>
> Looks like you resent it this morning as https://patchwork.kernel.org/patch/9914313/
Yes, sorry I wasn't sure I had send it and google could not find it,
so I assumed I did not send it.
> We can discard this one then I guess.
Ack.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-22 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17 10:48 [PATCH] hid: Fix system-control buttons on a multitouch interface not working Hans de Goede
2017-08-22 9:00 ` Benjamin Tissoires
2017-08-22 10:06 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).