From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined
Date: Mon, 28 Aug 2017 09:50:31 -0700 [thread overview]
Message-ID: <20170828165031.GD12195@dtor-ws> (raw)
In-Reply-To: <20170824144427.23873-1-alexandre.belloni@free-electrons.com>
On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote:
> mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only
> when MMU is selected.
>
> To avoid linking errors, make INPUT_M68K_BEEP depend on MMU.
Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU
dependency seems to be artificial.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/input/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 3872488c3fd7..7a44f633a413 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -178,7 +178,7 @@ config INPUT_SPARCSPKR
>
> config INPUT_M68K_BEEP
> tristate "M68k Beeper support"
> - depends on M68K
> + depends on M68K && MMU
>
> config INPUT_MAX77693_HAPTIC
> tristate "MAXIM MAX77693/MAX77843 haptic controller support"
> --
> 2.14.1
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-08-28 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 14:44 [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined Alexandre Belloni
2017-08-28 16:50 ` Dmitry Torokhov [this message]
2017-08-28 17:15 ` Geert Uytterhoeven
2017-08-29 0:24 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828165031.GD12195@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).