* [PATCH] input: elantech: make arrays debounce_packet static, reduces object code size
@ 2017-09-06 12:59 Colin King
2017-09-07 21:31 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-09-06 12:59 UTC (permalink / raw)
To: Ulrik De Bie, KT Liao, Matti Kurkela, Colin Ian King, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the arrays debounce_packet on the stack, instead make
them static. Makes the object code smaller by over 870 bytes:
Before:
text data bss dec hex filename
30553 9152 0 39705 9b19 drivers/input/mouse/elantech.o
After:
text data bss dec hex filename
29521 9312 0 38833 97b1 drivers/input/mouse/elantech.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/input/mouse/elantech.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 6428d6f4d568..b84cd978fce2 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -700,7 +700,9 @@ static int elantech_debounce_check_v2(struct psmouse *psmouse)
* When we encounter packet that matches this exactly, it means the
* hardware is in debounce status. Just ignore the whole packet.
*/
- const u8 debounce_packet[] = { 0x84, 0xff, 0xff, 0x02, 0xff, 0xff };
+ static const u8 debounce_packet[] = {
+ 0x84, 0xff, 0xff, 0x02, 0xff, 0xff
+ };
unsigned char *packet = psmouse->packet;
return !memcmp(packet, debounce_packet, sizeof(debounce_packet));
@@ -741,7 +743,9 @@ static int elantech_packet_check_v2(struct psmouse *psmouse)
static int elantech_packet_check_v3(struct psmouse *psmouse)
{
struct elantech_data *etd = psmouse->private;
- const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff };
+ static const u8 debounce_packet[] = {
+ 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff
+ };
unsigned char *packet = psmouse->packet;
/*
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] input: elantech: make arrays debounce_packet static, reduces object code size
2017-09-06 12:59 [PATCH] input: elantech: make arrays debounce_packet static, reduces object code size Colin King
@ 2017-09-07 21:31 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-09-07 21:31 UTC (permalink / raw)
To: Colin King
Cc: Ulrik De Bie, KT Liao, Matti Kurkela, linux-input,
kernel-janitors, linux-kernel
On Wed, Sep 06, 2017 at 01:59:44PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the arrays debounce_packet on the stack, instead make
> them static. Makes the object code smaller by over 870 bytes:
>
> Before:
> text data bss dec hex filename
> 30553 9152 0 39705 9b19 drivers/input/mouse/elantech.o
>
> After:
> text data bss dec hex filename
> 29521 9312 0 38833 97b1 drivers/input/mouse/elantech.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
> ---
> drivers/input/mouse/elantech.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 6428d6f4d568..b84cd978fce2 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -700,7 +700,9 @@ static int elantech_debounce_check_v2(struct psmouse *psmouse)
> * When we encounter packet that matches this exactly, it means the
> * hardware is in debounce status. Just ignore the whole packet.
> */
> - const u8 debounce_packet[] = { 0x84, 0xff, 0xff, 0x02, 0xff, 0xff };
> + static const u8 debounce_packet[] = {
> + 0x84, 0xff, 0xff, 0x02, 0xff, 0xff
> + };
> unsigned char *packet = psmouse->packet;
>
> return !memcmp(packet, debounce_packet, sizeof(debounce_packet));
> @@ -741,7 +743,9 @@ static int elantech_packet_check_v2(struct psmouse *psmouse)
> static int elantech_packet_check_v3(struct psmouse *psmouse)
> {
> struct elantech_data *etd = psmouse->private;
> - const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff };
> + static const u8 debounce_packet[] = {
> + 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff
> + };
> unsigned char *packet = psmouse->packet;
>
> /*
> --
> 2.14.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-07 21:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-06 12:59 [PATCH] input: elantech: make arrays debounce_packet static, reduces object code size Colin King
2017-09-07 21:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).