From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Guenter Roeck <groeck@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case
Date: Wed, 13 Sep 2017 07:49:50 -0700 [thread overview]
Message-ID: <20170913144950.GA1122@dtor-ws> (raw)
In-Reply-To: <nycvar.YFH.7.76.1709130701170.4703@jbgna.fhfr.qr>
On Wed, Sep 13, 2017 at 07:02:05AM -0700, Jiri Kosina wrote:
> On Fri, 8 Sep 2017, Dmitry Torokhov wrote:
>
> > From: Adrian Salido <salidoa@google.com>
> >
> > The buffer allocation is not currently accounting for an extra byte for
> > the report id. This can cause an out of bounds access in function
> > i2c_hid_set_or_send_report() with reportID > 15.
> >
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Missing signoff from the patch author?
Oops, I must have cut it off on accident while removing ChromeOS
specific tags, the original commit is here:
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212
>
> Also, I think this should have Cc: stable, right?
I usually let maintainers decide, but yes.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-09-13 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 17:55 [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Dmitry Torokhov
2017-09-13 14:02 ` Jiri Kosina
2017-09-13 14:49 ` Dmitry Torokhov [this message]
2017-09-13 14:52 ` Jiri Kosina
2017-09-13 15:00 ` Benson Leung
2017-09-13 16:18 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913144950.GA1122@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=groeck@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).