* [PATCH] Input: adxl34x - avoid int-in-bool-context warning
@ 2017-09-18 15:43 Steven Joruk
2017-09-20 19:13 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Steven Joruk @ 2017-09-18 15:43 UTC (permalink / raw)
To: michael.hennerich, dmitry.torokhov; +Cc: linux-input, Steven Joruk
The code is fine, but make it clear to the compiler.
drivers/input/misc/adxl34x.c:134:35: warning: ‘<<’ in boolean context
Signed-off-by: Steven Joruk <steven@joruk.com>
---
drivers/input/misc/adxl34x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
index 2b2d02f408bb..e0caaa0de454 100644
--- a/drivers/input/misc/adxl34x.c
+++ b/drivers/input/misc/adxl34x.c
@@ -796,7 +796,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
if (pdata->watermark) {
ac->int_mask |= WATERMARK;
- if (!FIFO_MODE(pdata->fifo_mode))
+ if (FIFO_MODE(pdata->fifo_mode) == 0)
ac->pdata.fifo_mode |= FIFO_STREAM;
} else {
ac->int_mask |= DATA_READY;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: adxl34x - avoid int-in-bool-context warning
2017-09-18 15:43 [PATCH] Input: adxl34x - avoid int-in-bool-context warning Steven Joruk
@ 2017-09-20 19:13 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-09-20 19:13 UTC (permalink / raw)
To: Steven Joruk; +Cc: michael.hennerich, linux-input
On Mon, Sep 18, 2017 at 04:43:57PM +0100, Steven Joruk wrote:
> The code is fine, but make it clear to the compiler.
>
> drivers/input/misc/adxl34x.c:134:35: warning: ‘<<’ in boolean context
>
> Signed-off-by: Steven Joruk <steven@joruk.com>
> ---
> drivers/input/misc/adxl34x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c
> index 2b2d02f408bb..e0caaa0de454 100644
> --- a/drivers/input/misc/adxl34x.c
> +++ b/drivers/input/misc/adxl34x.c
> @@ -796,7 +796,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
>
> if (pdata->watermark) {
> ac->int_mask |= WATERMARK;
> - if (!FIFO_MODE(pdata->fifo_mode))
> + if (FIFO_MODE(pdata->fifo_mode) == 0)
This has been NAKed before:
https://www.spinics.net/lists/linux-ide/msg54485.html
I'll pick up the V2 from Arnd that is better.
> ac->pdata.fifo_mode |= FIFO_STREAM;
> } else {
> ac->int_mask |= DATA_READY;
> --
> 2.14.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-20 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-18 15:43 [PATCH] Input: adxl34x - avoid int-in-bool-context warning Steven Joruk
2017-09-20 19:13 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).