From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: KT Liao <kt.liao@emc.com.tw>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
ulrik.debie-os@e2big.org, phoenix@emc.com.tw
Subject: Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad
Date: Fri, 22 Sep 2017 10:06:05 -0700 [thread overview]
Message-ID: <20170922170605.GA24037@dtor-ws> (raw)
In-Reply-To: <1506059436-3631-1-git-send-email-kt.liao@emc.com.tw>
On Fri, Sep 22, 2017 at 01:50:36PM +0800, KT Liao wrote:
> Original 20ms delay is a margin timing after a block writing
> in FW update flow.
>
> Sometimes it will cause fail during FW-updating if I2C timing delay.
> We offten see this issue in rockchip's I2C host.
>
> Extend the delay timing is the safest way to improve it.
>
> Signed-off-by: KT Liao <kt.liao@emc.com.tw>
Applied, thank you.
> ---
> drivers/input/mouse/elan_i2c_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
> index 80172f2..4db376c 100644
> --- a/drivers/input/mouse/elan_i2c_i2c.c
> +++ b/drivers/input/mouse/elan_i2c_i2c.c
> @@ -587,7 +587,7 @@ static int elan_i2c_write_fw_block(struct i2c_client *client,
> }
>
> /* Wait for F/W to update one page ROM data. */
> - msleep(20);
> + msleep(35);
>
> error = elan_i2c_read_cmd(client, ETP_I2C_IAP_CTRL_CMD, val);
> if (error) {
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2017-09-22 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 5:50 [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad KT Liao
2017-09-22 17:06 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922170605.GA24037@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kt.liao@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenix@emc.com.tw \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).