* [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad
@ 2017-09-22 5:50 KT Liao
2017-09-22 17:06 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: KT Liao @ 2017-09-22 5:50 UTC (permalink / raw)
To: linux-kernel, linux-input, dmitry.torokhov, ulrik.debie-os
Cc: phoenix, kt.liao
Original 20ms delay is a margin timing after a block writing
in FW update flow.
Sometimes it will cause fail during FW-updating if I2C timing delay.
We offten see this issue in rockchip's I2C host.
Extend the delay timing is the safest way to improve it.
Signed-off-by: KT Liao <kt.liao@emc.com.tw>
---
drivers/input/mouse/elan_i2c_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
index 80172f2..4db376c 100644
--- a/drivers/input/mouse/elan_i2c_i2c.c
+++ b/drivers/input/mouse/elan_i2c_i2c.c
@@ -587,7 +587,7 @@ static int elan_i2c_write_fw_block(struct i2c_client *client,
}
/* Wait for F/W to update one page ROM data. */
- msleep(20);
+ msleep(35);
error = elan_i2c_read_cmd(client, ETP_I2C_IAP_CTRL_CMD, val);
if (error) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad
2017-09-22 5:50 [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad KT Liao
@ 2017-09-22 17:06 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-09-22 17:06 UTC (permalink / raw)
To: KT Liao; +Cc: linux-kernel, linux-input, ulrik.debie-os, phoenix
On Fri, Sep 22, 2017 at 01:50:36PM +0800, KT Liao wrote:
> Original 20ms delay is a margin timing after a block writing
> in FW update flow.
>
> Sometimes it will cause fail during FW-updating if I2C timing delay.
> We offten see this issue in rockchip's I2C host.
>
> Extend the delay timing is the safest way to improve it.
>
> Signed-off-by: KT Liao <kt.liao@emc.com.tw>
Applied, thank you.
> ---
> drivers/input/mouse/elan_i2c_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
> index 80172f2..4db376c 100644
> --- a/drivers/input/mouse/elan_i2c_i2c.c
> +++ b/drivers/input/mouse/elan_i2c_i2c.c
> @@ -587,7 +587,7 @@ static int elan_i2c_write_fw_block(struct i2c_client *client,
> }
>
> /* Wait for F/W to update one page ROM data. */
> - msleep(20);
> + msleep(35);
>
> error = elan_i2c_read_cmd(client, ETP_I2C_IAP_CTRL_CMD, val);
> if (error) {
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-22 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 5:50 [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad KT Liao
2017-09-22 17:06 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).