From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] Input: stmfts - use devm_device_add_group
Date: Fri, 22 Sep 2017 10:06:16 -0700 [thread overview]
Message-ID: <20170922170616.GB24037@dtor-ws> (raw)
In-Reply-To: <20170922075238.22938-1-andi.shyti@samsung.com>
On Fri, Sep 22, 2017 at 04:52:38PM +0900, Andi Shyti wrote:
> instead of sysfs_create_group.
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/stmfts.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..2351199189a4 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
> }
> }
>
> - err = sysfs_create_group(&sdata->client->dev.kobj,
> - &stmfts_attribute_group);
> + err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
> if (err)
> return err;
>
> @@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
> static int stmfts_remove(struct i2c_client *client)
> {
> pm_runtime_disable(&client->dev);
> - sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
>
> return 0;
> }
> --
> 2.14.1
>
--
Dmitry
prev parent reply other threads:[~2017-09-22 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170922075230epcas1p141c817bf8524e69bba1a3482c62e9f67@epcas1p1.samsung.com>
2017-09-22 7:52 ` [PATCH] Input: stmfts - use devm_device_add_group Andi Shyti
2017-09-22 17:06 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922170616.GB24037@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).