From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: sa1111ps2 - extend test delay
Date: Tue, 26 Sep 2017 09:57:26 -0700 [thread overview]
Message-ID: <20170926165726.GE14833@dtor-ws> (raw)
In-Reply-To: <E1dwsgD-0006Hy-5u@rmk-PC.armlinux.org.uk>
On Tue, Sep 26, 2017 at 05:25:53PM +0100, Russell King wrote:
> A 2us delay is too small for the bus to settle after writing to the
> register. Extend to 10us which gives more reliable results.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied, thank you.
> ---
> drivers/input/serio/sa1111ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/sa1111ps2.c b/drivers/input/serio/sa1111ps2.c
> index f1c036260d25..f9e5c793f4f0 100644
> --- a/drivers/input/serio/sa1111ps2.c
> +++ b/drivers/input/serio/sa1111ps2.c
> @@ -212,7 +212,7 @@ static unsigned int ps2_test_one(struct ps2if *ps2if,
>
> writel_relaxed(PS2CR_ENA | mask, ps2if->base + PS2CR);
>
> - udelay(2);
> + udelay(10);
>
> val = readl_relaxed(ps2if->base + PS2STAT);
> return val & (PS2STAT_KBC | PS2STAT_KBD);
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2017-09-26 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 16:25 [PATCH] Input: sa1111ps2 - extend test delay Russell King
2017-09-26 16:57 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926165726.GE14833@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox