From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi@etezian.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi.shyti@samsung.com>
Subject: Re: [PATCH 07/12] Input: ili210x - use managed devm_device_add_group
Date: Fri, 29 Sep 2017 16:45:38 -0700 [thread overview]
Message-ID: <20170929234538.GJ14362@dtor-ws> (raw)
In-Reply-To: <20170929203839.7010-8-andi@etezian.org>
On Sat, Sep 30, 2017 at 05:38:34AM +0900, Andi Shyti wrote:
> Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> and friends") has added the the managed version for creating
> sysfs group files.
>
> Use devm_device_add_group instead of sysfs_create_group and
> remove the relative sysfs_remove_group and goto label.
>
> Signed-off-by: Andi Shyti <andi@etezian.org>
> ---
> drivers/input/touchscreen/ili210x.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
> index 6f76eeedf465..03a6aca2941f 100644
> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -266,7 +266,7 @@ static int ili210x_i2c_probe(struct i2c_client *client,
> goto err_free_mem;
> }
>
> - error = sysfs_create_group(&dev->kobj, &ili210x_attr_group);
> + error = devm_device_add_group(dev, &ili210x_attr_group);
> if (error) {
> dev_err(dev, "Unable to create sysfs attributes, err: %d\n",
> error);
> @@ -276,7 +276,7 @@ static int ili210x_i2c_probe(struct i2c_client *client,
> error = input_register_device(priv->input);
> if (error) {
> dev_err(dev, "Cannot register input device, err: %d\n", error);
> - goto err_remove_sysfs;
> + goto err_free_irq;
> }
>
> device_init_wakeup(dev, 1);
> @@ -287,8 +287,6 @@ static int ili210x_i2c_probe(struct i2c_client *client,
>
> return 0;
>
> -err_remove_sysfs:
> - sysfs_remove_group(&dev->kobj, &ili210x_attr_group);
> err_free_irq:
> free_irq(client->irq, priv);
> err_free_mem:
> @@ -301,7 +299,6 @@ static int ili210x_i2c_remove(struct i2c_client *client)
> {
> struct ili210x *priv = i2c_get_clientdata(client);
>
> - sysfs_remove_group(&client->dev.kobj, &ili210x_attr_group);
Wrong ordering, the sysfs attributes will be removed only after device
has been town down.
> free_irq(priv->client->irq, priv);
> cancel_delayed_work_sync(&priv->dwork);
> input_unregister_device(priv->input);
> --
> 2.14.2
>
--
Dmitry
next prev parent reply other threads:[~2017-09-29 23:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 20:38 [PATCH 00/12] use managed devm_device_add_group for all touchscreen drivers Andi Shyti
2017-09-29 20:38 ` [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group Andi Shyti
2017-09-29 23:32 ` Dmitry Torokhov
2017-10-27 6:11 ` Andi Shyti
2017-09-29 20:38 ` [PATCH 02/12] Input: ad7879 " Andi Shyti
2017-09-29 23:48 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 03/12] Input: ads7846 " Andi Shyti
2017-09-29 23:46 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 04/12] Input: atmel_mxt_ts " Andi Shyti
2017-09-29 23:46 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 05/12] Input: edt-ft5x06 " Andi Shyti
2017-09-29 23:42 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 06/12] Input: elants_i2c " Andi Shyti
2017-09-29 23:38 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 07/12] Input: ili210x " Andi Shyti
2017-09-29 23:45 ` Dmitry Torokhov [this message]
2017-09-29 20:38 ` [PATCH 08/12] Input: melfas_mip4 " Andi Shyti
2017-09-29 23:38 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 09/12] Input: raydium_i2c_ts " Andi Shyti
2017-09-29 23:39 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 10/12] Input: rohm_bu21023 " Andi Shyti
2017-09-29 23:39 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 11/12] Input: tsc200x-core " Andi Shyti
2017-09-29 23:44 ` Dmitry Torokhov
2017-09-29 20:38 ` [PATCH 12/12] Input: wdt87xx_i2c " Andi Shyti
2017-09-29 23:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929234538.GJ14362@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).