* [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static
@ 2017-10-02 22:05 Colin King
2017-10-02 22:18 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-10-02 22:05 UTC (permalink / raw)
To: Dmitry Torokhov, Guenter Roeck, Andrew Duggan, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The array rmi_f54_report_type_names is local to the source and does
not need to be in global scope, so make it static. Also make the array
const char * const
Cleans up sparse warning:
symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/input/rmi4/rmi_f54.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index f5206e2c767e..70f6310f1d15 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -73,7 +73,7 @@ enum rmi_f54_report_type {
F54_MAX_REPORT_TYPE,
};
-const char *rmi_f54_report_type_names[] = {
+static const char * const rmi_f54_report_type_names[] = {
[F54_REPORT_NONE] = "Unknown",
[F54_8BIT_IMAGE] = "Normalized 8-Bit Image",
[F54_16BIT_IMAGE] = "Normalized 16-Bit Image",
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static
2017-10-02 22:05 [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static Colin King
@ 2017-10-02 22:18 ` Guenter Roeck
2017-10-05 0:00 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2017-10-02 22:18 UTC (permalink / raw)
To: Colin King
Cc: Dmitry Torokhov, Andrew Duggan, linux-input, kernel-janitors,
linux-kernel
On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array rmi_f54_report_type_names is local to the source and does
> not need to be in global scope, so make it static. Also make the array
> const char * const
>
> Cleans up sparse warning:
> symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/input/rmi4/rmi_f54.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index f5206e2c767e..70f6310f1d15 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
> F54_MAX_REPORT_TYPE,
> };
>
> -const char *rmi_f54_report_type_names[] = {
> +static const char * const rmi_f54_report_type_names[] = {
> [F54_REPORT_NONE] = "Unknown",
> [F54_8BIT_IMAGE] = "Normalized 8-Bit Image",
> [F54_16BIT_IMAGE] = "Normalized 16-Bit Image",
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static
2017-10-02 22:18 ` Guenter Roeck
@ 2017-10-05 0:00 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2017-10-05 0:00 UTC (permalink / raw)
To: Guenter Roeck
Cc: Colin King, Andrew Duggan, linux-input, kernel-janitors,
linux-kernel
On Mon, Oct 02, 2017 at 03:18:52PM -0700, Guenter Roeck wrote:
> On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The array rmi_f54_report_type_names is local to the source and does
> > not need to be in global scope, so make it static. Also make the array
> > const char * const
> >
> > Cleans up sparse warning:
> > symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Applied, thank you.
>
> > ---
> > drivers/input/rmi4/rmi_f54.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> > index f5206e2c767e..70f6310f1d15 100644
> > --- a/drivers/input/rmi4/rmi_f54.c
> > +++ b/drivers/input/rmi4/rmi_f54.c
> > @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
> > F54_MAX_REPORT_TYPE,
> > };
> >
> > -const char *rmi_f54_report_type_names[] = {
> > +static const char * const rmi_f54_report_type_names[] = {
> > [F54_REPORT_NONE] = "Unknown",
> > [F54_8BIT_IMAGE] = "Normalized 8-Bit Image",
> > [F54_16BIT_IMAGE] = "Normalized 16-Bit Image",
> > --
> > 2.14.1
> >
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-05 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-02 22:05 [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static Colin King
2017-10-02 22:18 ` Guenter Roeck
2017-10-05 0:00 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).