From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH] Input: atmel_mxt_ts - Remove unnecessary byte_offset check Date: Sun, 8 Oct 2017 20:41:16 +0100 Message-ID: <20171008194116.GB29090@lava.h.shmanahar.org> References: <1507488258-22409-1-git-send-email-chris.gekas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1507488258-22409-1-git-send-email-chris.gekas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Christos Gkekas Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Sun, Oct 08, 2017 at 07:44:18PM +0100, Christos Gkekas wrote: > Variable byte_offset is unsigned so checking whether it is greater or > equal to zero is redundant. > > Signed-off-by: Christos Gkekas Yep - looks sensible to me. Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 7659bc4..baafaed 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -1356,7 +1356,7 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, > > byte_offset = reg + i - cfg_start_ofs; > > - if (byte_offset >= 0 && byte_offset < config_mem_size) { > + if (byte_offset < config_mem_size) { > *(config_mem + byte_offset) = val; > } else { > dev_err(dev, "Bad object: reg:%d, T%d, ofs=%d\n", > -- > 2.7.4 >