From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: synaptics - Disable kernel tracking on SMBus devices Date: Mon, 9 Oct 2017 20:51:35 -0700 Message-ID: <20171010035135.GB4601@dtor-ws> References: <1506629239-5940-1-git-send-email-aduggan@synaptics.com> <20170929080844.GA14877@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170929080844.GA14877@mail.corp.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Tissoires Cc: Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Kamil =?iso-8859-1?Q?P=E1ral?= List-Id: linux-input@vger.kernel.org On Fri, Sep 29, 2017 at 10:08:44AM +0200, Benjamin Tissoires wrote: > On Sep 28 2017 or thereabouts, Andrew Duggan wrote: > > In certain situations kernel tracking seems to be getting confused > > and incorrectly reporting the slot of a contact. On example is when > > the user does a three finger click or tap and then places two fingers > > on the touchpad in the same area. The kernel tracking code seems to > > continue to think that there are three contacts on the touchpad and > > incorrectly alternates the slot of one of the contacts. The result that > > is the input subsystem reports a stream of button press and release > > events as the reported slot changes. > > > > Kernel tracking was originally enabled to prevent cursor jumps, but it > > is unclear how much of an issue kernel jumps actually are. This patch > > simply disabled kernel tracking for now. > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640 > > > > Signed-off-by: Andrew Duggan > > Tested-by: Kamil Páral > > Acked-by: Benjamin Tissoires > > Thanks Andrew for the patch! Applied, thank you. > > Cheers, > Benjamin > > > --- > > drivers/input/mouse/synaptics.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > index 5af0b7d..ee5466a 100644 > > --- a/drivers/input/mouse/synaptics.c > > +++ b/drivers/input/mouse/synaptics.c > > @@ -1709,8 +1709,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, > > .sensor_pdata = { > > .sensor_type = rmi_sensor_touchpad, > > .axis_align.flip_y = true, > > - /* to prevent cursors jumps: */ > > - .kernel_tracking = true, > > + .kernel_tracking = false, > > .topbuttonpad = topbuttonpad, > > }, > > .f30_data = { > > -- > > 2.7.4 > > -- Dmitry