From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen Date: Wed, 18 Oct 2017 17:27:05 -0700 Message-ID: <20171019002705.wrfz2ffioxjp2xu5@dtor-ws> References: <20170919062906.501-1-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-io0-f195.google.com ([209.85.223.195]:44615 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdJSA1J (ORCPT ); Wed, 18 Oct 2017 20:27:09 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Michael Nazzareno Trimarchi Cc: Vignesh R , linux-input@vger.kernel.org, LKML , Linux OMAP Mailing List On Wed, Oct 18, 2017 at 07:18:11AM +0200, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Sep 19, 2017 at 8:29 AM, Vignesh R wrote: > > From: Jeff Lance > > > > Step config setting for 5 wire touchscreen is incorrect for Y coordinates. > > It was broken while we moved to DT. If you look close at the offending > > commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made > > configurable"), the change was: > > > > - STEPCONFIG_XNP | STEPCONFIG_YPN; > > + ts_dev->bit_xn | ts_dev->bit_yp; > > > > while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the > > same. > > > > Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable") > > Signed-off-by: Jeff Lance > > [vigneshr@ti.com: Rebase to v4.14-rc1] > > Signed-off-by: Vignesh R > > --- > > > > Tested on AM335x EVM with 5 wire tsc module. Also sanity tested > > on a 4 wire tsc as well. > > > > drivers/input/touchscreen/ti_am335x_tsc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > > index 7953381d939a..f1043ae71dcc 100644 > > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > > @@ -161,7 +161,7 @@ static void titsc_step_config(struct titsc *ts_dev) > > break; > > case 5: > > config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 | > > - ts_dev->bit_xn | ts_dev->bit_yp; > > + STEPCONFIG_XNP | STEPCONFIG_YPN; > > break; > > case 8: > > config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp); > > -- > > Looks sane to me. Applied, thank you. > > Michael > > > 2.14.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dmitry