From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org,
Quentin Schulz <quentin.schulz@free-electrons.com>
Subject: Re: [PATCH 4.14 REGRESSION fix] Input: axp20x-pek - Fix module not auto-loading for axp221 pek
Date: Thu, 19 Oct 2017 15:39:03 -0700 [thread overview]
Message-ID: <20171019223903.mlwiibjsgyz2c4ck@dtor-ws> (raw)
In-Reply-To: <20171016133422.14327-1-hdegoede@redhat.com>
On Mon, Oct 16, 2017 at 03:34:22PM +0200, Hans de Goede wrote:
> Now that we have a platform_device_id table and multiple supported ids
> we should be using MODULE_DEVICE_TABLE instead of MODULE_ALIAS.
>
> This fixes a regression on Bay and Cherry Trail devices, where the power
> button is now enumerated as an "axp221-pek" and it was impossible to
> wakeup these devices from suspend since the module did not load.
>
> Cc: Quentin Schulz <quentin.schulz@free-electrons.com>
> Fixes: c3cc94470bd3 ("Input: axp20x-pek - add support for AXP221 PEK")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thank you.
> ---
> drivers/input/misc/axp20x-pek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c
> index 6cee5adc3b5c..debeeaeb8812 100644
> --- a/drivers/input/misc/axp20x-pek.c
> +++ b/drivers/input/misc/axp20x-pek.c
> @@ -403,6 +403,7 @@ static const struct platform_device_id axp_pek_id_match[] = {
> },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(platform, axp_pek_id_match);
>
> static struct platform_driver axp20x_pek_driver = {
> .probe = axp20x_pek_probe,
> @@ -417,4 +418,3 @@ module_platform_driver(axp20x_pek_driver);
> MODULE_DESCRIPTION("axp20x Power Button");
> MODULE_AUTHOR("Carlo Caione <carlo@caione.org>");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:axp20x-pek");
> --
> 2.14.2
>
--
Dmitry
prev parent reply other threads:[~2017-10-19 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:34 [PATCH 4.14 REGRESSION fix] Input: axp20x-pek - Fix module not auto-loading for axp221 pek Hans de Goede
2017-10-19 22:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019223903.mlwiibjsgyz2c4ck@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox