From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Andrew Duggan <aduggan@synaptics.com>,
Yiannis Marangos <yiannis.marangos@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
Date: Wed, 25 Oct 2017 09:14:40 -0700 [thread overview]
Message-ID: <20171025161440.rbjdg7dvqrsseqdc@dtor-ws> (raw)
In-Reply-To: <20171025073155.GE13605@mail.corp.redhat.com>
On Wed, Oct 25, 2017 at 09:31:55AM +0200, Benjamin Tissoires wrote:
> On Oct 24 2017 or thereabouts, Andrew Duggan wrote:
> > Hi Dmitry,
> >
> > On 10/24/2017 11:19 AM, Dmitry Torokhov wrote:
> > > On Tue, Oct 10, 2017 at 09:04:20PM +0300, Yiannis Marangos wrote:
> > > > Hi guys,
> > > >
> > > > As I understand the second part of the patchset will take a while until it get
> > > > merged. Is it possible to merge the first part only? Without this, LEN0073 users
> > > > can not use psmouse.synaptics_intertouch=1 as a workaround. LEN0073 is not
> > > > usable at all unless users patch the kernel manually.
> > > Benjamin, Andrew, any comments/objections on expanding the acceptable
> > > version range?
> >
> > I didn't comment earlier since I didn't have any specific info about SMBus
> > v3. But, looking at the spec for v3 it sounds like our v2 touchpads should
> > be compatible with a v3 bus.
> >
> > "This version of the specification is a superset of previous versions, 1.0,
> > 1.1, and 2.0. The intent is that all devices compliant with these previous
> > versions are compliant with this version."
> >
> > From http://smbus.org/specs/SMBus_3_0_20141220.pdf pg 8 section 1.3.
> >
> > Based on that quote and the fact that it seems to work for Yiannis makes me
> > think that this change is probably ok.
> >
>
> I concur. I thought the version was Synaptics' one, but if it is the
> SMBus protocol they are following, allowing v3 is OK.
>
> Aceked-By: Benjamin Tissoires <benjamin.tissoires@redhat.com>
OK, great.
Yiannis, I need your signed-off-by, it is missing from the patch.
Thanks!
--
Dmitry
next prev parent reply other threads:[~2017-10-25 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 14:06 [PATCH v2 0/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos
2017-10-06 14:06 ` [PATCH v2 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-10-10 18:04 ` Yiannis Marangos
2017-10-24 18:19 ` Dmitry Torokhov
2017-10-24 23:50 ` Andrew Duggan
2017-10-25 7:31 ` Benjamin Tissoires
2017-10-25 16:14 ` Dmitry Torokhov [this message]
2017-10-06 14:06 ` [PATCH v2 2/2] Input: synaptics - Lenovo X1 Carbon 5 should use SMBUS/RMI Yiannis Marangos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025161440.rbjdg7dvqrsseqdc@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=yiannis.marangos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox