linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: multitouch: Fix alphabetic sorting of mt_devices table.
Date: Fri, 3 Nov 2017 10:57:57 +0100	[thread overview]
Message-ID: <20171103095757.GF1738@mail.corp.redhat.com> (raw)
In-Reply-To: <20171102202339.9225-1-hdegoede@redhat.com>

On Nov 02 2017 or thereabouts, Hans de Goede wrote:
> Fix alphabetic sorting of mt_devices hid_device_id table.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---

BTW, this one is
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/hid/hid-multitouch.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 9e8c4d2ba11d..bb939f6990f1 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1605,14 +1605,6 @@ static const struct hid_device_id mt_devices[] = {
>  		MT_USB_DEVICE(USB_VENDOR_ID_TURBOX,
>  			USB_DEVICE_ID_TURBOX_TOUCHSCREEN_MOSART) },
>  
> -	/* Panasonic panels */
> -	{ .driver_data = MT_CLS_PANASONIC,
> -		MT_USB_DEVICE(USB_VENDOR_ID_PANASONIC,
> -			USB_DEVICE_ID_PANABOARD_UBT780) },
> -	{ .driver_data = MT_CLS_PANASONIC,
> -		MT_USB_DEVICE(USB_VENDOR_ID_PANASONIC,
> -			USB_DEVICE_ID_PANABOARD_UBT880) },
> -
>  	/* Novatek Panel */
>  	{ .driver_data = MT_CLS_NSMU,
>  		MT_USB_DEVICE(USB_VENDOR_ID_NOVATEK,
> @@ -1623,6 +1615,14 @@ static const struct hid_device_id mt_devices[] = {
>  		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>  			USB_VENDOR_ID_NTRIG, 0x1b05) },
>  
> +	/* Panasonic panels */
> +	{ .driver_data = MT_CLS_PANASONIC,
> +		MT_USB_DEVICE(USB_VENDOR_ID_PANASONIC,
> +			USB_DEVICE_ID_PANABOARD_UBT780) },
> +	{ .driver_data = MT_CLS_PANASONIC,
> +		MT_USB_DEVICE(USB_VENDOR_ID_PANASONIC,
> +			USB_DEVICE_ID_PANABOARD_UBT880) },
> +
>  	/* PixArt optical touch screen */
>  	{ .driver_data = MT_CLS_INRANGE_CONTACTNUMBER,
>  		MT_USB_DEVICE(USB_VENDOR_ID_PIXART,
> -- 
> 2.14.3
> 

      parent reply	other threads:[~2017-11-03  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 20:23 [PATCH 1/2] HID: multitouch: Fix alphabetic sorting of mt_devices table Hans de Goede
2017-11-02 20:23 ` [PATCH 2/2] HID: multitouch: Fix BTN_LEFT 0-1-0-1 events on Novatek mt touchpad Hans de Goede
2017-11-03  9:56   ` Benjamin Tissoires
2017-11-03 12:17     ` Hans de Goede
2017-11-03 13:09       ` Benjamin Tissoires
2017-11-06 14:58         ` Hans de Goede
2017-11-03  9:57 ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171103095757.GF1738@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).