From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW
Date: Fri, 3 Nov 2017 12:17:56 -0700 [thread overview]
Message-ID: <20171103191756.jee5272ml2lfgcvx@dtor-ws> (raw)
In-Reply-To: <8c454b54-98a7-492d-b861-83d125306f86@rwthex-w2-a.rwth-ad.de>
On Fri, Nov 03, 2017 at 08:03:26PM +0100, Stefan Brüns wrote:
> Sync events are sent by sparse_keymap_report_entry for normal KEY_*
> events, and are generated by several drivers after generating
> SW_* events, so sparse_keymap_report_entry should do the same.
>
> Without the sync, events are accumulated in the kernel.
>
> Currently, no driver uses sparse-keymap for SW_* events, but
> it is required for the intel-vbtn platform driver to generate
> SW_TABLET_MODE events.
>
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Applied, thank you.
> ---
>
> drivers/input/sparse-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
> index bb0349fa64bc..fd03e55768c9 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -255,6 +255,7 @@ void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *k
>
> case KE_VSW:
> input_report_switch(dev, ke->sw.code, value);
> + input_sync(dev);
> break;
> }
> }
> --
> 2.14.3
>
--
Dmitry
prev parent reply other threads:[~2017-11-03 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171103190329.15194-1-stefan.bruens@rwth-aachen.de>
2017-11-03 19:03 ` [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW Stefan Brüns
2017-11-03 19:17 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103191756.jee5272ml2lfgcvx@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).