* [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW [not found] <20171103190329.15194-1-stefan.bruens@rwth-aachen.de> @ 2017-11-03 19:03 ` Stefan Brüns 2017-11-03 19:17 ` Dmitry Torokhov 0 siblings, 1 reply; 2+ messages in thread From: Stefan Brüns @ 2017-11-03 19:03 UTC (permalink / raw) To: platform-driver-x86 Cc: Stefan Brüns, Dmitry Torokhov, linux-kernel, linux-input Sync events are sent by sparse_keymap_report_entry for normal KEY_* events, and are generated by several drivers after generating SW_* events, so sparse_keymap_report_entry should do the same. Without the sync, events are accumulated in the kernel. Currently, no driver uses sparse-keymap for SW_* events, but it is required for the intel-vbtn platform driver to generate SW_TABLET_MODE events. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- drivers/input/sparse-keymap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c index bb0349fa64bc..fd03e55768c9 100644 --- a/drivers/input/sparse-keymap.c +++ b/drivers/input/sparse-keymap.c @@ -255,6 +255,7 @@ void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *k case KE_VSW: input_report_switch(dev, ke->sw.code, value); + input_sync(dev); break; } } -- 2.14.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW 2017-11-03 19:03 ` [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW Stefan Brüns @ 2017-11-03 19:17 ` Dmitry Torokhov 0 siblings, 0 replies; 2+ messages in thread From: Dmitry Torokhov @ 2017-11-03 19:17 UTC (permalink / raw) To: Stefan Brüns; +Cc: platform-driver-x86, linux-kernel, linux-input On Fri, Nov 03, 2017 at 08:03:26PM +0100, Stefan Brüns wrote: > Sync events are sent by sparse_keymap_report_entry for normal KEY_* > events, and are generated by several drivers after generating > SW_* events, so sparse_keymap_report_entry should do the same. > > Without the sync, events are accumulated in the kernel. > > Currently, no driver uses sparse-keymap for SW_* events, but > it is required for the intel-vbtn platform driver to generate > SW_TABLET_MODE events. > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> Applied, thank you. > --- > > drivers/input/sparse-keymap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c > index bb0349fa64bc..fd03e55768c9 100644 > --- a/drivers/input/sparse-keymap.c > +++ b/drivers/input/sparse-keymap.c > @@ -255,6 +255,7 @@ void sparse_keymap_report_entry(struct input_dev *dev, const struct key_entry *k > > case KE_VSW: > input_report_switch(dev, ke->sw.code, value); > + input_sync(dev); > break; > } > } > -- > 2.14.3 > -- Dmitry ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 19:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171103190329.15194-1-stefan.bruens@rwth-aachen.de>
2017-11-03 19:03 ` [PATCH 1/4] Input: sparse-keymap - send sync event for KE_SW/KW_VSW Stefan Brüns
2017-11-03 19:17 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).