From: Darren Hart <dvhart@infradead.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org,
AceLan Kao <acelan.kao@canonical.com>,
Andy Shevchenko <andy@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events
Date: Thu, 9 Nov 2017 17:34:17 -0800 [thread overview]
Message-ID: <20171110013417.GB9783@fury> (raw)
In-Reply-To: <024c7574-12f2-4708-9f90-1192856df401@rwthex-w2-a.rwth-ad.de>
On Thu, Nov 09, 2017 at 11:44:33PM +0100, Stefan Brüns wrote:
> Currently all key events use autorelease, but this forbids use as a
> modifier key.
>
> As all event codes come in even/odd pairs, we can lookup the key type
> (KE_KEY/KE_IGNORE) for the key up event corresponding to the currently
> handled key down event. If the key up is ignored, we keep setting the
> autorelease flag for the key down.
>
What is the use-case for using these buttons as modifiers? I'm picturing one of
these devices in tablet mode, with a physical Windows button. What other action
does a user want to modify by holding the Windows button down? Or is there
another scenario we're trying to support here?
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-11-10 1:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171109224436.16472-1-stefan.bruens@rwth-aachen.de>
2017-11-09 22:44 ` [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events Stefan Brüns
2017-11-10 1:34 ` Darren Hart [this message]
2017-11-10 1:58 ` Stefan Brüns
2017-11-10 2:11 ` Darren Hart
2017-11-10 2:44 ` Stefan Brüns
2017-11-10 2:15 ` Darren Hart
2017-12-08 20:33 ` Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:34 ` Bastien Nocera
2017-11-30 17:51 ` Brüns, Stefan
2017-12-05 18:50 ` Jason Gerecke
2018-01-25 16:23 ` Jason Gerecke
2017-11-10 1:41 ` Darren Hart
2017-11-09 22:44 ` [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:30 ` Bastien Nocera
2017-11-09 23:46 ` Darren Hart
2017-11-10 0:23 ` Stefan Brüns
2017-11-10 0:15 ` Stefan Brüns
2017-11-10 0:39 ` Bastien Nocera
2017-11-10 0:53 ` Darren Hart
2017-11-10 1:54 ` Darren Hart
2017-11-10 2:20 ` Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button Stefan Brüns
2017-11-09 23:40 ` Bastien Nocera
2017-11-10 0:21 ` Stefan Brüns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110013417.GB9783@fury \
--to=dvhart@infradead.org \
--cc=acelan.kao@canonical.com \
--cc=andy@infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).