From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: maxime.ripard@free-electrons.com, wens@csie.org,
linux@roeck-us.net, wsa@the-dreams.de,
daniel.thompson@linaro.org, mcuos.com@gmail.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/10] Input: ep93xx_keypad: Fix platform_get_irq's error checking
Date: Fri, 17 Nov 2017 11:50:08 -0800 [thread overview]
Message-ID: <20171117195008.6dev6chhzkn6fqri@dtor-ws> (raw)
In-Reply-To: <1510946132-13554-2-git-send-email-arvind.yadav.cs@gmail.com>
On Sat, Nov 18, 2017 at 12:45:23AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/input/keyboard/ep93xx_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..67efdc9 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
> }
>
> keypad->irq = platform_get_irq(pdev, 0);
> - if (!keypad->irq) {
> + if (keypad->irq < 0) {
> err = -ENXIO;
We should not clobber error here, so we need:
err = keypad->irq;
> goto failed_free;
> }
> --
> 2.7.4
>
--
Dmitry
next prev parent reply other threads:[~2017-11-17 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 19:15 [PATCH 00/10] Handle platform_get_irq's error checking and returns Arvind Yadav
2017-11-17 19:15 ` [PATCH 01/10] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-17 19:50 ` Dmitry Torokhov [this message]
2017-11-17 19:15 ` [PATCH 02/10] Input: omap4-keypad: " Arvind Yadav
2017-11-17 20:25 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 03/10] Input: twl4030_keypad: " Arvind Yadav
2017-11-17 20:27 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 04/10] Input: serio: " Arvind Yadav
2017-11-17 20:27 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 05/10] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Arvind Yadav
2017-11-17 19:15 ` [PATCH 06/10] Input: w90p910_ts: " Arvind Yadav
2017-11-17 19:15 ` [PATCH 07/10] Input: sun4i-ts: " Arvind Yadav
2017-11-17 19:56 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 08/10] Input: twl4030-pwrbutton: " Arvind Yadav
2017-11-17 19:56 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 09/10] Input: sirfsoc-onkey: " Arvind Yadav
2017-11-17 19:58 ` Dmitry Torokhov
2017-11-17 19:15 ` [PATCH 10/10] Input: palmas-pwrbutton: " Arvind Yadav
2017-11-18 8:18 ` [PATCH 00/10] Handle platform_get_irq's error checking and returns Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117195008.6dev6chhzkn6fqri@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mcuos.com@gmail.com \
--cc=wens@csie.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).