From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 01/10] Input: ep93xx_keypad: Fix platform_get_irq's error checking Date: Fri, 17 Nov 2017 11:50:08 -0800 Message-ID: <20171117195008.6dev6chhzkn6fqri@dtor-ws> References: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com> <1510946132-13554-2-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-io0-f196.google.com ([209.85.223.196]:46586 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756258AbdKQTuM (ORCPT ); Fri, 17 Nov 2017 14:50:12 -0500 Content-Disposition: inline In-Reply-To: <1510946132-13554-2-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Arvind Yadav Cc: maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Sat, Nov 18, 2017 at 12:45:23AM +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > drivers/input/keyboard/ep93xx_keypad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c > index f77b295..67efdc9 100644 > --- a/drivers/input/keyboard/ep93xx_keypad.c > +++ b/drivers/input/keyboard/ep93xx_keypad.c > @@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev) > } > > keypad->irq = platform_get_irq(pdev, 0); > - if (!keypad->irq) { > + if (keypad->irq < 0) { > err = -ENXIO; We should not clobber error here, so we need: err = keypad->irq; > goto failed_free; > } > -- > 2.7.4 > -- Dmitry