From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines
Date: Sat, 18 Nov 2017 13:49:42 +0100 [thread overview]
Message-ID: <20171118124942.GA31864@kroah.com> (raw)
In-Reply-To: <CAOFm3uEScMh9PmQMuGvUY39sw=0iJhs0BezQHUhg2-KWZ1fRuQ@mail.gmail.com>
On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote:
> On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Please do, I got rid of all of the DRIVER_VERSION crap in the
> > drivers/usb/ tree a release or so ago, as they make no sense at all.
> > The other defines are also really silly and can be cleaned up too.
> >
> > Want me to do that for drivers/input/ for you?
> >
> > thanks,
> >
> > greg "I'm a janitor now" k-h
>
>
> Thing could get worse: you could become a documentalist like tglx turned into.
>
> For the fun, another weird thingie that I once stumbled upon in an
> out-of-tree third-party module:
>
> MODULE_LICENSE("\x47\x50\x4c\x20\x76\x32");
>
> ... which was most likely from a GPL-shy closet Free software
> advocate: this is "GPL v2" in ASCII.
Hah, we've seen worse with people trying to put '0x00' in the middle of
the string to fake out the string checking logic. Whenever stuff like
that gets pointed out to the legal department of the company involved,
stuff gets fixed fast, trying to 'circumvent' a license check is really
frowned apon by almost all legal juristictions :)
So, if you want to point that code out to me offline, I'm sure I could
have some fun...
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-18 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:17 [PATCH] input: remove unneeded DRIVER_LICENSE #defines Greg Kroah-Hartman
2017-11-17 14:51 ` Philippe Ombredanne
2018-01-17 0:41 ` Dmitry Torokhov
2017-11-17 20:33 ` Dmitry Torokhov
2017-11-18 10:27 ` Greg Kroah-Hartman
2017-11-18 12:39 ` Philippe Ombredanne
2017-11-18 12:49 ` Greg Kroah-Hartman [this message]
2017-11-18 13:27 ` Philippe Ombredanne
2017-11-18 18:32 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118124942.GA31864@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).