From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@roeck-us.net, wsa@the-dreams.de,
daniel.thompson@linaro.org, mcuos.com@gmail.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 5/10 v2] Input: cpcap-pwrbutton: Handle return value of platform_get_irq
Date: Sat, 18 Nov 2017 10:27:04 -0800 [thread overview]
Message-ID: <20171118182704.2jtdu562iokx6zo2@dtor-ws> (raw)
In-Reply-To: <20171118082122.GB31757@n2100.armlinux.org.uk>
On Sat, Nov 18, 2017 at 08:21:22AM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 18, 2017 at 02:36:53AM +0530, Arvind Yadav wrote:
> > platform_get_irq() can fail here and we must check its return value.
>
> The test should be <= 0, and you need to return an error code for the
> 0 case.
Instead of polluting the drivers with special handling of 0 vs negative
error we should have platform_get_irq[_byname] return -EINVAL if it sees
0.
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-11-18 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 21:06 [PATCH 5/10 v2] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Arvind Yadav
2017-11-18 8:21 ` Russell King - ARM Linux
2017-11-18 18:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118182704.2jtdu562iokx6zo2@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mcuos.com@gmail.com \
--cc=wens@csie.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox