From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: dmitry.torokhov@gmail.com, pombredanne@nexb.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] input: pegasus_notetaker: add license information
Date: Mon, 27 Nov 2017 08:52:52 +0100 [thread overview]
Message-ID: <20171127075252.GA19416@kroah.com> (raw)
In-Reply-To: <20171127074401.16388-1-martink@posteo.de>
On Mon, Nov 27, 2017 at 08:44:01AM +0100, Martin Kepplinger wrote:
> This adds an SPDX license identifier to this driver I wrote some time back.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
>
> Thanks for the feedback. GPL2+ was what I had in mind. My bad. And as I
> already see a lot of SPDX tags using /**/ comments, I'll use that too.
> I think if it is hand-written, it shouldn't look too ugly. And in case
> that's really a no-go, it seems that many many files need to be changed
> again in any case.
.h files should be the only ones using /* */, and that is for the ones
that break the build if they use // (usually arch-specific and uapi
files)
So please use // as Linus asked to have done.
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-27 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 8:45 [PATCH] input: pegasus_notetaker: add license information Martin Kepplinger
2017-11-26 0:42 ` Dmitry Torokhov
2017-11-26 8:59 ` Greg Kroah-Hartman
2017-11-26 11:28 ` Philippe Ombredanne
2017-11-27 7:55 ` Greg Kroah-Hartman
2017-11-27 7:44 ` [PATCH v2] " Martin Kepplinger
2017-11-27 7:52 ` Greg KH [this message]
2017-11-27 8:02 ` [PATCH v3] " Martin Kepplinger
2017-11-27 8:07 ` Greg KH
2017-11-27 10:19 ` Philippe Ombredanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127075252.GA19416@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).