From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP
Date: Mon, 27 Nov 2017 09:16:31 +0100 [thread overview]
Message-ID: <20171127081631.GB30708@mail.corp.redhat.com> (raw)
In-Reply-To: <20171125055054.GA2139@dhcp-128-65.nay.redhat.com>
On Nov 25 2017 or thereabouts, Dave Young wrote:
> This mouse keep disconnecting in runleve 3 like below, add it needs the
> quirk to mute the anoying messages.
>
> [ 111.230555] usb 2-2: USB disconnect, device number 6
> [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd
> [ 112.941594] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a
> [ 112.984866] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> [ 113.027731] usb 2-2: Product: HP USB Optical Mouse
> [ 113.069977] usb 2-2: Manufacturer: PixArt
> [ 113.113500] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0002/input/input14
> [ 113.156787] hid-generic 0003:03F0:094A.0002: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0
> [ 173.262642] usb 2-2: USB disconnect, device number 7
> [ 174.750244] usb 2-2: new low-speed USB device number 8 using xhci_hcd
> [ 174.935740] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a
> [ 174.990435] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> [ 175.014984] usb 2-2: Product: HP USB Optical Mouse
> [ 175.037886] usb 2-2: Manufacturer: PixArt
> [ 175.061794] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0003/input/input15
> [ 175.084946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0
>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/usbhid/hid-quirks.c | 1 +
Patch looks good and should be good for stable too, but in the file
hid-quirks.c file has been moved one folder up. Please rebase the patch
on top of https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/log/?h=for-4.16/hid-quirks-cleanup/_base
It should be merged in linux-next in the next few days normally.
Jiri, how can we deal with such stable-ish patches?
Cheers,
Benjamin
> 2 files changed, 2 insertions(+)
>
> --- linux-x86.orig/drivers/hid/hid-ids.h
> +++ linux-x86/drivers/hid/hid-ids.h
> @@ -535,6 +535,7 @@
> #define USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A 0x0a4a
> #define USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A 0x0b4a
> #define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE 0x134a
> +#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A 0x094a
>
> #define USB_VENDOR_ID_HUION 0x256c
> #define USB_DEVICE_ID_HUION_TABLET 0x006e
> --- linux-x86.orig/drivers/hid/usbhid/hid-quirks.c
> +++ linux-x86/drivers/hid/usbhid/hid-quirks.c
> @@ -99,6 +99,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
> + { USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_IDEACOM, USB_DEVICE_ID_IDEACOM_IDC6680, HID_QUIRK_MULTI_INPUT },
> { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007, HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL },
next prev parent reply other threads:[~2017-11-27 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 5:53 [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP Dave Young
2017-11-27 8:16 ` Benjamin Tissoires [this message]
2017-11-27 8:32 ` Greg KH
2017-11-27 8:49 ` Benjamin Tissoires
2017-11-27 9:15 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127081631.GB30708@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dyoung@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).