* [PATCH] HID: core: lower log level for unknown main item tags to warnings
@ 2017-12-06 16:54 Hans de Goede
2017-12-06 17:24 ` Benjamin Tissoires
2017-12-07 10:06 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2017-12-06 16:54 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: Hans de Goede, linux-input
Given all the effort distros have done with splash-screens to give
users a nice clean boot experience, we really want dmesg --level=err
to not print anything unless there is a real problem with either the
hardware or the kernel. Buggy HID descriptors unfortunately happen
all too often, so lower the log level to warning keep the console
clear of error messages such as:
[ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/hid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 7297b1d1300c..c2560aae5542 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item)
ret = hid_add_field(parser, HID_FEATURE_REPORT, data);
break;
default:
- hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag);
+ hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag);
ret = 0;
}
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: core: lower log level for unknown main item tags to warnings
2017-12-06 16:54 [PATCH] HID: core: lower log level for unknown main item tags to warnings Hans de Goede
@ 2017-12-06 17:24 ` Benjamin Tissoires
2017-12-07 10:06 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-12-06 17:24 UTC (permalink / raw)
To: Hans de Goede; +Cc: Jiri Kosina, linux-input
On Wed, Dec 6, 2017 at 5:54 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Given all the effort distros have done with splash-screens to give
> users a nice clean boot experience, we really want dmesg --level=err
> to not print anything unless there is a real problem with either the
> hardware or the kernel. Buggy HID descriptors unfortunately happen
> all too often, so lower the log level to warning keep the console
> clear of error messages such as:
>
> [ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/hid-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 7297b1d1300c..c2560aae5542 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item)
> ret = hid_add_field(parser, HID_FEATURE_REPORT, data);
> break;
> default:
> - hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag);
> + hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag);
> ret = 0;
> }
>
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: core: lower log level for unknown main item tags to warnings
2017-12-06 16:54 [PATCH] HID: core: lower log level for unknown main item tags to warnings Hans de Goede
2017-12-06 17:24 ` Benjamin Tissoires
@ 2017-12-07 10:06 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-12-07 10:06 UTC (permalink / raw)
To: Hans de Goede; +Cc: Benjamin Tissoires, linux-input
On Wed, 6 Dec 2017, Hans de Goede wrote:
> Given all the effort distros have done with splash-screens to give
> users a nice clean boot experience, we really want dmesg --level=err
> to not print anything unless there is a real problem with either the
> hardware or the kernel. Buggy HID descriptors unfortunately happen
> all too often, so lower the log level to warning keep the console
> clear of error messages such as:
>
> [ 441.079664] apple 0005:05AC:0239.0003: unknown main item tag 0x0
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/hid/hid-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 7297b1d1300c..c2560aae5542 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -551,7 +551,7 @@ static int hid_parser_main(struct hid_parser *parser, struct hid_item *item)
> ret = hid_add_field(parser, HID_FEATURE_REPORT, data);
> break;
> default:
> - hid_err(parser->device, "unknown main item tag 0x%x\n", item->tag);
> + hid_warn(parser->device, "unknown main item tag 0x%x\n", item->tag);
> ret = 0;
Applied to for-4.15/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-07 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 16:54 [PATCH] HID: core: lower log level for unknown main item tags to warnings Hans de Goede
2017-12-06 17:24 ` Benjamin Tissoires
2017-12-07 10:06 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).