From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
stable@vger.kernel.org
Subject: [PATCH 1/2] input - leds: do not iterate over non initialized leds
Date: Thu, 14 Dec 2017 14:25:21 +0100 [thread overview]
Message-ID: <20171214132522.20346-2-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <20171214132522.20346-1-benjamin.tissoires@redhat.com>
We only instantiate the led classes if there is a definition in
input_led_info[].
However, the max for EV_LED is bigger than the values filled in this
array, and there are some holes in it.
In .connect(), we check for these holes, but in leds_init_work() we do
not, leading to some nice kernel oopses.
Found by running https://github.com/whot/fuzzydevice
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/input/input-leds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/input-leds.c b/drivers/input/input-leds.c
index 83d930f7396a..c86eb3d648bf 100644
--- a/drivers/input/input-leds.c
+++ b/drivers/input/input-leds.c
@@ -94,6 +94,9 @@ static void leds_init_work(struct work_struct *work)
int led_no = 0;
for_each_set_bit(led_code, leds->handle.dev->ledbit, LED_CNT) {
+ if (!input_led_info[led_code].name)
+ continue;
+
led = &leds->leds[led_no];
down_read(&led->cdev.trigger_lock);
--
2.14.3
next prev parent reply other threads:[~2017-12-14 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 13:25 [PATCH 0/2] input - leds: fix bugs found by fuzzing Benjamin Tissoires
2017-12-14 13:25 ` Benjamin Tissoires [this message]
2017-12-14 13:25 ` [PATCH 2/2] input - leds: fix input_led_disconnect path Benjamin Tissoires
2017-12-15 0:19 ` Samuel Thibault
2017-12-16 0:48 ` Dmitry Torokhov
2017-12-20 15:11 ` Benjamin Tissoires
2017-12-20 18:20 ` Dmitry Torokhov
2017-12-20 18:42 ` Benjamin Tissoires
2017-12-15 0:16 ` [PATCH 0/2] input - leds: fix bugs found by fuzzing Samuel Thibault
2017-12-15 8:04 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214132522.20346-2-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=samuel.thibault@ens-lyon.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).