From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Shyti Subject: Re: [PATCH] touchscreen: mms114: add support for mms152 Date: Tue, 19 Dec 2017 18:10:09 +0900 Message-ID: <20171219091009.GD25647@gangnam.samsung> References: <20171218124933.1803-1-simon@lineageos.org> <20171219062252.GC25647@gangnam.samsung> <20171219080409.GA27703@lineageos.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-disposition: inline In-reply-to: <20171219080409.GA27703-WP75azK+jQYgsBAKwltoeQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Shields Cc: Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Simon, > > > #ifdef CONFIG_OF > > > static const struct of_device_id mms114_dt_match[] = { > > > - { .compatible = "melfas,mms114" }, > > > + { > > > + .compatible = "melfas,mms114", > > > + .data = (void *)TYPE_MMS114, > > > + }, { > > > + .compatible = "melfas,mms152", > > > + .data = (void *)TYPE_MMS152, > > > > You are not documenting the new "melfas,mms152" compatible in > > Documentation/devicetree/bindings/input/touchscreen/mms114.txt > > Yes I am - "melfas,mms152" is added to the documentation > as part of this patch. Is there something wrong with what I've done > there? Oh yes, sorry! I missed it while snipping the code :) Please ignore this comment, then. Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html