From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] Revert "Input: trackpoint - add new trackpoint firmware ID" Date: Sat, 30 Dec 2017 16:32:13 +0100 Message-ID: <20171230153213.GA28219@kroah.com> References: <20171230152213.GA2099@marax.lan.yath.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:60628 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdL3PcW (ORCPT ); Sat, 30 Dec 2017 10:32:22 -0500 Content-Disposition: inline In-Reply-To: <20171230152213.GA2099@marax.lan.yath.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Sebastian Schmidt Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, Aaron Ma On Sat, Dec 30, 2017 at 04:22:13PM +0100, Sebastian Schmidt wrote: > This reverts commit ec667683c532c93fb41e100e5d61a518971060e2, which > breaks the Trackpoint on ThinkPad X1 Carbon Gen5 (Model 20HR). That > commit intended to add support for later firmware versions to the > trackpoint driver, however, the version is reported in the second byte > whereas the change was made to the magic byte preceding that version. > The update package linked by Lenovo suggests that 20HR models use an > ALPS Touchpad instead. > > Signed-off-by: Sebastian Schmidt > Acked-by: Greg KH Um, I didn't ack this patch, don't ever put something like that on a patch unless it is offered by the person. thanks, greg k-h