From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: misc: gpio_tilt: Delete driver Date: Mon, 1 Jan 2018 22:50:17 -0800 Message-ID: <20180102065017.gobr623tzmhem7l7@dtor-ws> References: <20171227121547.20558-1-linus.walleij@linaro.org> <14171345.p7a3jPx4Si@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-it0-f65.google.com ([209.85.214.65]:38086 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbeABGuU (ORCPT ); Tue, 2 Jan 2018 01:50:20 -0500 Received: by mail-it0-f65.google.com with SMTP id r6so38457988itr.3 for ; Mon, 01 Jan 2018 22:50:20 -0800 (PST) Content-Disposition: inline In-Reply-To: <14171345.p7a3jPx4Si@phil> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Heiko Stuebner Cc: Linus Walleij , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, Dec 27, 2017 at 02:51:45PM +0100, Heiko Stuebner wrote: > Hi Linus, > > Am Mittwoch, 27. Dezember 2017, 13:15:47 CET schrieb Linus Walleij: > > This driver was merged in 2011 as a tool for detecting the orientation > > of a screen. The device driver assumes board file setup using the > > platform data from . But no boards in the > > kernel tree defines this platform data. > > > > As I am faced with refactoring drivers to use GPIO descriptors and > > pass decriptor tables from boards, or use the device tree device > > drivers like these creates a serious problem: I cannot fix them and > > cannot test them, not even compile-test them with a system actually > > using it (no in-tree boardfile). > > > > I suggest to delete this driver and rewrite it using device tree if > > it is still in use on actively maintained systems. > > > > I can also offer to rewrite it out of the blue using device tree if > > someone promise to test it and help me iterate it. > > > > Cc: Heiko Stübner > > Signed-off-by: Linus Walleij > > --- > > Heiko: not meaning to be militant here, just contain the situation, > > as stated: if you like the driver and can test it, I can reimplement > > it from scratch using device tree. > > It seems that piece of hardware (gpio-connected orientation-sensors) > was really only used in the one s3c24xx-based device I hacked on in 2011. > > I somehow lost focus from trying to do the s3c24xx devicetree migration > when I started hacking on Rockchip stuff, so while I do have the devices > still around, I don't think I'll find the time and energy trying to get a > recent kernel to run on them anyway, so I'm fine with dropping the driver. > It's simple enough to get reintroduced if someone really finds a device > using it or time to redo the ereader support using devicetree. > > So long story short > Acked-by: Heiko Stuebner Applied, thank you. -- Dmitry