linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Sebastian Schmidt <yath@yath.de>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: trackpoint - add new trackpoint firmware ID"
Date: Mon, 1 Jan 2018 23:08:11 -0800	[thread overview]
Message-ID: <20180102070811.p7gfaq3vr55sdbd3@dtor-ws> (raw)
In-Reply-To: <901a0a66-eb83-9dcd-658c-5b09eabcab88@canonical.com>

Hi Aaron,

On Sun, Dec 31, 2017 at 04:51:09PM +0800, Aaron Ma wrote:
> 1, Commit ec667683c53 addes support of the new trackpoint.
> The trackpoint can be identified as "TPPS/2 IBM TrackPoint" and set
> properties OK. Trackpoint enabled some enhanced features.
> Without this commit there will be no scroll mode when xf86-input-evdev
> is used.
> 
> 2, trackpoint.c export a speed of sysfs,
> the speed sys file can't be set right value on X1 Carbon 5th. This issue
> is caused by trackpoint firmware.

No, I do not believe that this is an issue with the firmware. Rather, it
seems that Lenovo is multi-sourcing trackpoint for their devices, and
not all of them implement the IBM trackpoint protocol. We will need to
contact Elan to figure out what capabilities their trackpoints have.

> Workaround is to use xinput/xorg/udev/GUI to set trackpoint speed.

I'd rather we did not force users to do that.

> 
> 3, Windowds tool Trackpointdetect.exe shows it is ELAN (ID:03) in error log.
> After debugging psmouse driver on it, the IDs and FW/hardware version is
> not ELAN. Forcing to load ELAN driver will not make it work.

We do not have a special driver for Elan trackpoints and if they do not
fully implement IBM trackpoint protocol, then standard PS/2 mode should
be used, at least until someone creates a proper Elan trackpoint driver.

The original "magic ID" for the IBM trcakpoints was 0x1. This value was
described in the original trackpoint spec and has not changed since late
90th. Now we have 0x2 and 0x3. Could they indicate ALPS and Elan
trackpoints respectively? What ID does your Yoga report? Does it support
all features exported by the trackpoint driver (speed, sensitivity,
inertia, etc)?

Thanks.

-- 
Dmitry

  reply	other threads:[~2018-01-02  7:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30 15:22 [PATCH] Revert "Input: trackpoint - add new trackpoint firmware ID" Sebastian Schmidt
2017-12-30 15:32 ` Greg KH
2017-12-30 15:41   ` Sebastian Schmidt
2017-12-31  4:37 ` Aaron Ma
2017-12-31  8:26   ` Greg KH
2017-12-31  8:51     ` Aaron Ma
2018-01-02  7:08       ` Dmitry Torokhov [this message]
2018-01-02 13:57         ` Aaron Ma
2018-01-05  0:56           ` Dmitry Torokhov
2018-01-05 13:29             ` Aaron Ma
2018-01-05 16:23               ` Dmitry Torokhov
2018-01-07  6:52                 ` Dmitry Torokhov
2018-01-08 15:11                   ` Sebastian Schmidt
2018-01-09  0:40                     ` Dmitry Torokhov
2018-01-09  1:35                       ` Peter Hutterer
2018-01-14 20:39                   ` ulrik.debie-os
2018-01-14 20:57                     ` ulrik.debie-os
2018-01-16 23:49                     ` Dmitry Torokhov
2018-01-21 20:37                       ` ulrik.debie-os
2018-01-21 21:08                         ` Dmitry Torokhov
2018-01-22 18:41                           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102070811.p7gfaq3vr55sdbd3@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aaron.ma@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=yath@yath.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).