From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Andrii Chepurnyi <andrii_chepurnyi@epam.com>
Subject: Re: [PATCH] xen/input: do not advertise multi-touch pressure support
Date: Tue, 2 Jan 2018 09:39:53 -0800 [thread overview]
Message-ID: <20180102173953.tje4tz2ng3fnfijw@dtor-ws> (raw)
In-Reply-To: <1514880775-31185-1-git-send-email-andr2000@gmail.com>
On Tue, Jan 02, 2018 at 10:12:55AM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Some user-space applications expect multi-touch pressure
> on contact to be reported if it is advertised in device
> properties. Otherwise, such applications may treat reports
> not as actual touches, but hovering. Currently this is
> only advertised, but not reported.
> Fix this by not advertising that ABS_MT_PRESSURE is supported.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
Applied, thank you.
> ---
> drivers/input/misc/xen-kbdfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 6bf56bb5f8d9..d91f3b1c5375 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
> 0, width, 0, 0);
> input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
> 0, height, 0, 0);
> - input_set_abs_params(mtouch, ABS_MT_PRESSURE,
> - 0, 255, 0, 0);
>
> ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
> if (ret) {
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2018-01-02 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 8:12 [PATCH] xen/input: do not advertise multi-touch pressure support Oleksandr Andrushchenko
2018-01-02 17:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102173953.tje4tz2ng3fnfijw@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andr2000@gmail.com \
--cc=andrii_chepurnyi@epam.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox