public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier
Date: Fri, 5 Jan 2018 08:49:58 -0800	[thread overview]
Message-ID: <20180105164958.csojn6vhy72bwoac@dtor-ws> (raw)
In-Reply-To: <20180105095715.GA6679@gangnam.samsung>

Hi Andi,

On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote:
> Hi Dmitry,
> 
> this is a kind ping, would you also mind giving me a feedback to

Yes, sorry. Could you please split the patch for each driver
individually? Also, until we have an update to the CodingStyle doc
mandating the C++ style comments, I'd prefer keeping the original style
of comments. So // for the SPDX line and /* */ for the rest.

Thanks!

> all the previous patches I sent?

Could you tell me what reviews I owe you? My mailbox keeps growing :(

> 
> Thanks,
> Andi
> 
> On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote:
> > Replace the original license statement with the SPDX identifier.
> > 
> > Update also the copyright owner adding myself as co-owner of the
> > copyright.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> > ---
> >  drivers/input/touchscreen/s6sy761.c | 15 +++++----------
> >  drivers/input/touchscreen/stmfts.c  | 15 +++++----------
> >  2 files changed, 10 insertions(+), 20 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
> > index 26b1cb8a88ec..675efa93d444 100644
> > --- a/drivers/input/touchscreen/s6sy761.c
> > +++ b/drivers/input/touchscreen/s6sy761.c
> > @@ -1,13 +1,8 @@
> > -/*
> > - * Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > - * Author: Andi Shyti <andi.shyti@samsung.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > - *
> > - * Samsung S6SY761 Touchscreen device driver
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Samsung S6SY761 Touchscreen device driver
> > +//
> > +// Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com>
> >  
> >  #include <asm/unaligned.h>
> >  #include <linux/delay.h>
> > diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> > index c12d01899939..2a123e20a42e 100644
> > --- a/drivers/input/touchscreen/stmfts.c
> > +++ b/drivers/input/touchscreen/stmfts.c
> > @@ -1,13 +1,8 @@
> > -/*
> > - * Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > - * Author: Andi Shyti <andi.shyti@samsung.com>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> > - *
> > - * STMicroelectronics FTS Touchscreen device driver
> > - */
> > +// SPDX-License-Identifier: GPL-2.0
> > +// STMicroelectronics FTS Touchscreen device driver
> > +//
> > +// Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > +// Copyright (c) 2017 Andi Shyti <andi.shyti@samsung.com>
> >  
> >  #include <linux/delay.h>
> >  #include <linux/i2c.h>
> > -- 
> > 2.15.1
> > 

-- 
Dmitry

  reply	other threads:[~2018-01-05 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171212074156epcas2p4fefff65c3316ec1aa9b3d7797aaca550@epcas2p4.samsung.com>
2017-12-12  7:41 ` [PATCH] Input: stmfts,s6sy671 - add SPDX identifier Andi Shyti
2018-01-05  9:57   ` Andi Shyti
2018-01-05 16:49     ` Dmitry Torokhov [this message]
2018-01-09  5:23       ` Andi Shyti
2018-01-23  1:41         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105164958.csojn6vhy72bwoac@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox