Re: [PATCH 2/3] Input: twl6040-vibra: fix child-node lookup

Johan Hovold
2017-11-13T09:16:29Z

On Mon, Nov 13, 2017 at 08:30:53AM +0100, H. Nikolaus Schaller wrote:
> Hi Johan,
>
> > Am 11.11.2017 um 16:43 schrieb Johan Hovold <johan@kernel.org>:
> >
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at parent rather than just matching on
> > its children.
> >
> > Later sanity checks on node properties (which would likely be missing)
> > should prevent this from causing much trouble however, especially as the
> > original premature free of the parent node has already been fixed
> > separately (but that "fix" was apparently never backported to stable).
> >
> > Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
> > Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management")
> > Cc: stable <stable@vger.kernel.org> # 3.6
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: H. Nikolaus Schaller <hns@goldelico.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Tested-By: H. Nikolaus Schaller <hns@goldelico.com> (on Pyra OMAP5 hardware)
>
> I also tested your twl4030-vibra patch on GTA04.
>
> No regressions observed.

Thanks for testing.

Johan