Re: [PATCH 1/3] Input: twl4030-vibra: fix sibling-node lookup

Johan Hovold
2018-01-08T13:55:03Z

On Mon, Dec 11, 2017 at 11:21:21AM +0100, Johan Hovold wrote:
> On Sat, Nov 11, 2017 at 04:43:37PM +0100, Johan Hovold wrote:
> > A helper purported to look up a child node based on its name was using
> > the wrong of-helper and ended up prematurely freeing the parent of-node
> > while searching the whole device tree depth-first starting at the parent
> > node.
> >
> > Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel")
> > Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning")
> > Cc: stable <stable@vger.kernel.org> # 3.7
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Cc: Marek Belisko <marek@goldelico.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>
> Just wanted to send a reminder about this series. I believe these bugs
> need to be fixes regardless of whether MFD-core eventually provides some
> means of avoiding such lookups in cell drivers (i.e. the discussion
> which appears to have stalled).

Another month, another reminder: Will you pick this series up for 4.16,
Dmitry?

Thanks,
Johan