From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Shyti Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier Date: Tue, 09 Jan 2018 14:23:31 +0900 Message-ID: <20180109052331.GC11443@gangnam.samsung> References: <20171212074149.7844-1-andi.shyti@samsung.com> <20180105095715.GA6679@gangnam.samsung> <20180105164958.csojn6vhy72bwoac@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Content-disposition: inline In-reply-to: <20180105164958.csojn6vhy72bwoac@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Philippe Ombredanne List-Id: linux-input@vger.kernel.org Hi Dmitry, On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote: > Hi Andi, > > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > this is a kind ping, would you also mind giving me a feedback to > > Yes, sorry. Could you please split the patch for each driver > individually? Also, until we have an update to the CodingStyle doc > mandating the C++ style comments, I'd prefer keeping the original style > of comments. So // for the SPDX line and /* */ for the rest. I was actually following Linus guideline [1] [2]. I also had the same discussion previously in another context [3]. Please let me know if you still want a mixed style of comments in the next patch. Thanks, Andi [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 ... └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2 [2] https://marc.info/?l=linux-kernel&m=150964359922353 [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2