public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported
Date: Fri, 12 Jan 2018 10:18:30 -0800	[thread overview]
Message-ID: <20180112181830.ccpkltghgkj3oh3e@dtor-ws> (raw)
In-Reply-To: <06bbeca0-8a90-8935-9be3-f154db0b9fe9@canonical.com>

Hi Aaron,

On Fri, Jan 12, 2018 at 08:45:17PM +0800, Aaron Ma wrote:
> Only this laptop had been confirmed is ALPS: 0102 – FF02 trackpoint, it
> return 0 of extended button.
> I saw the other device that returned 0, but don't have it now, so the ID
> can not be checked.
> 
> ThinkPad always have 3 buttons installed, I suggest always set 0x33 for
> button info when the button info returned 0.

I am really uncomfortable at us chipping away all validations in
trackpont protocol. The newer trackpoints (Elan, ALPS, etc) will be
taken care of with my patch that will not even try to fetch extended
button data for 0x02 - 0x04 extended ID devices, but unless we have a
concrete example of 0x01 responding with 0 for button info I will not
apply this patch.

Thanks.

-- 
Dmitry

  reply	other threads:[~2018-01-12 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12  6:46 [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported Aaron Ma
2018-01-12  8:39 ` Dmitry Torokhov
2018-01-12 12:45   ` Aaron Ma
2018-01-12 18:18     ` Dmitry Torokhov [this message]
2018-01-13  2:34       ` Aaron Ma
2018-01-16 23:07         ` Dmitry Torokhov
2018-01-21 20:10           ` ulrik.debie-os
2018-01-21 21:14             ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180112181830.ccpkltghgkj3oh3e@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=aaron.ma@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox