From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines
Date: Tue, 16 Jan 2018 16:41:14 -0800 [thread overview]
Message-ID: <20180117004114.gpy552mfz2jo4fay@dtor-ws> (raw)
In-Reply-To: <CAOFm3uG9QVCTEvV-_pjBGgKoHOWi6ps2tp=NABuHinOQi+QeTw@mail.gmail.com>
On Fri, Nov 17, 2017 at 03:51:31PM +0100, Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference. For some of these drivers, the #define is just a
> > few lines above the MODULE_LICENSE() line, which is extra pointless.
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2018-01-17 0:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 14:17 [PATCH] input: remove unneeded DRIVER_LICENSE #defines Greg Kroah-Hartman
2017-11-17 14:51 ` Philippe Ombredanne
2018-01-17 0:41 ` Dmitry Torokhov [this message]
2017-11-17 20:33 ` Dmitry Torokhov
2017-11-18 10:27 ` Greg Kroah-Hartman
2017-11-18 12:39 ` Philippe Ombredanne
2017-11-18 12:49 ` Greg Kroah-Hartman
2017-11-18 13:27 ` Philippe Ombredanne
2017-11-18 18:32 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117004114.gpy552mfz2jo4fay@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).