From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>,
Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier
Date: Mon, 22 Jan 2018 17:41:11 -0800 [thread overview]
Message-ID: <20180123014111.qt76xd7dnjikpmm7@dtor-ws> (raw)
In-Reply-To: <20180109052331.GC11443@gangnam.samsung>
On Tue, Jan 09, 2018 at 02:23:31PM +0900, Andi Shyti wrote:
> Hi Dmitry,
>
> On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote:
> > Hi Andi,
> >
> > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote:
> > > Hi Dmitry,
> > >
> > > this is a kind ping, would you also mind giving me a feedback to
> >
> > Yes, sorry. Could you please split the patch for each driver
> > individually? Also, until we have an update to the CodingStyle doc
> > mandating the C++ style comments, I'd prefer keeping the original style
> > of comments. So // for the SPDX line and /* */ for the rest.
>
> I was actually following Linus guideline [1] [2]. I also had the
> same discussion previously in another context [3].
>
> Please let me know if you still want a mixed style of comments in
> the next patch.
Eh, I guess it does not matter in the grand scheme of things; applied as
is.
Thank you.
>
> Thanks,
> Andi
>
> [1] https://marc.info/?l=linux-kernel&m=151163713125320&w=2
> ...
> └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
> ...
> └-> https://marc.info/?l=linux-kernel&m=151163867325641&w=2
>
> [2] https://marc.info/?l=linux-kernel&m=150964359922353
> [3] https://marc.info/?l=linux-kernel&m=151312974503109&w=2
--
Dmitry
prev parent reply other threads:[~2018-01-23 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171212074156epcas2p4fefff65c3316ec1aa9b3d7797aaca550@epcas2p4.samsung.com>
2017-12-12 7:41 ` [PATCH] Input: stmfts,s6sy671 - add SPDX identifier Andi Shyti
2018-01-05 9:57 ` Andi Shyti
2018-01-05 16:49 ` Dmitry Torokhov
2018-01-09 5:23 ` Andi Shyti
2018-01-23 1:41 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123014111.qt76xd7dnjikpmm7@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).