From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Simon Shields <simon@lineageos.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values
Date: Mon, 29 Jan 2018 15:33:35 -0800 [thread overview]
Message-ID: <20180129233335.ikqioeetkkvocblm@dtor-ws> (raw)
In-Reply-To: <20180129232923.GW7575@gangnam.samsung>
On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote:
> Hi Dmitry,
>
> On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote:
> > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote:
> > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> >
> > But why?
>
> I think this patch is trivial and the subject itself is quite
> self-explanatory and the commit message would be a copy-paste of
> it.
Here is where we disagree. Why lowercase is preferred over uppercase? Do
we have this in coding style (and I completely forgot about it)? Or is
it your preference (mine is too to be fair, but I also do not care
about churning the code for it)?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2018-01-29 23:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180129113330epcas2p353fa87845f4a1e21661032f16b11be82@epcas2p3.samsung.com>
2018-01-29 11:33 ` [PATCH 0/8] Melfas MMS114 touchscreen cleanups Andi Shyti
2018-01-29 11:33 ` [PATCH 1/8] Input: mms114 - use smbus functions whenever possible Andi Shyti
2018-01-29 11:33 ` [PATCH 2/8] Input: mms114 - get read of custm i2c read/write functions Andi Shyti
2018-01-29 19:01 ` Dmitry Torokhov
2018-01-29 23:25 ` Andi Shyti
2018-01-29 11:33 ` [PATCH 3/8] Input: mms114 - replace mdelay with msleep Andi Shyti
2018-01-29 19:46 ` Dmitry Torokhov
2018-01-29 11:33 ` [PATCH 4/8] Input: mms114 - remove unused variable Andi Shyti
2018-01-29 18:43 ` Dmitry Torokhov
2018-01-29 23:27 ` Andi Shyti
2018-01-29 11:33 ` [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values Andi Shyti
2018-01-29 18:56 ` Dmitry Torokhov
2018-01-29 23:29 ` Andi Shyti
2018-01-29 23:33 ` Dmitry Torokhov [this message]
2018-01-29 23:41 ` Andi Shyti
2018-01-29 11:33 ` [PATCH 6/8] Input: mms114 - Use BIT() macro instead of explicit shifting Andi Shyti
2018-01-29 19:46 ` Dmitry Torokhov
2018-01-29 11:33 ` [PATCH 7/8] Input: mms114 - add SPDX identifier Andi Shyti
2018-01-29 19:46 ` Dmitry Torokhov
2018-01-31 6:07 ` Andi Shyti
2018-01-31 7:31 ` Marcus Folkesson
2018-01-31 22:53 ` Dmitry Torokhov
2018-02-01 0:50 ` Andi Shyti
2018-02-01 0:49 ` Andi Shyti
2018-01-29 11:33 ` [PATCH 8/8] Input: mms114 - fix typo in definition Andi Shyti
2018-01-29 19:47 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129233335.ikqioeetkkvocblm@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox