From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 1/3] Input: gpio-keys - add support for wakeup event action Date: Tue, 13 Feb 2018 10:25:22 -0800 Message-ID: <20180213182521.GA51247@rodete-desktop-imager.corp.google.com> References: <20180210110907.5504-1-jeffy.chen@rock-chips.com> <20180210110907.5504-2-jeffy.chen@rock-chips.com> <20180212221309.GA66974@ban.mtv.corp.google.com> <059e2aa9-bf94-517d-a132-abe851ec69f7@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <059e2aa9-bf94-517d-a132-abe851ec69f7@collabora.com> Sender: linux-kernel-owner@vger.kernel.org To: Enric Balletbo i Serra Cc: Jeffy Chen , linux-kernel@vger.kernel.org, briannorris@google.com, dtor@google.com, dianders@google.com, Thomas Gleixner , Joseph Lo , stephen lu , Dmitry Torokhov , Kate Stewart , linux-input@vger.kernel.org, Greg Kroah-Hartman , Philippe Ombredanne , Arvind Yadav List-Id: linux-input@vger.kernel.org Hi Enric, On Tue, Feb 13, 2018 at 11:40:44AM +0100, Enric Balletbo i Serra wrote: > On 12/02/18 23:13, Brian Norris wrote: > > On Sat, Feb 10, 2018 at 07:09:05PM +0800, Jeffy Chen wrote: > >> Add support for specifying event actions to trigger wakeup when using > >> the gpio-keys input device as a wakeup source. > >> > >> This would allow the device to configure when to wakeup the system. For > >> example a gpio-keys input device for pen insert, may only want to wakeup > >> the system when ejecting the pen. > >> > >> Suggested-by: Brian Norris > >> Signed-off-by: Jeffy Chen > >> --- > >> > >> Changes in v2: > >> Specify wakeup event action instead of irq trigger type as Brian > >> suggested. [...] > Not sure if you were aware but there is also some discussion related to this, > maybe we can join the efforts? > > v1: https://patchwork.kernel.org/patch/10208261/ > v2: https://patchwork.kernel.org/patch/10211147/ Thanks for the pointers. IIUC, that's talking about a different problem: how to utilize a GPIO key in level-triggered mode. That touches similar code, but it doesn't really have anything to do with configuring a different wakeup trigger type. The two patches would need to be reconciled, if they both are going to be merged. But otherwise, I think they're perfectly fine to be separate. Brian