From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Folkesson Subject: Re: [PATCH v4 1/4] HID: add driver for Valve Steam Controller Date: Thu, 1 Mar 2018 08:50:17 +0100 Message-ID: <20180301075017.GB8901@gmail.com> References: <20180228184322.29636-1-rodrigorivascosta@gmail.com> <20180228184322.29636-2-rodrigorivascosta@gmail.com> <20180228224926.GA7009@casa> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180228224926.GA7009@casa> Sender: linux-kernel-owner@vger.kernel.org To: Rodrigo Rivas Costa Cc: Andy Shevchenko , Jiri Kosina , Benjamin Tissoires , "Pierre-Loup A. Griffais" , Cameron Gutman , =?iso-8859-1?Q?Cl=E9ment?= VUCHENER , Linux Kernel Mailing List , linux-input List-Id: linux-input@vger.kernel.org Rodrigo, On Wed, Feb 28, 2018 at 11:49:26PM +0100, Rodrigo Rivas Costa wrote: > On Wed, Feb 28, 2018 at 09:21:15PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 28, 2018 at 8:43 PM, Rodrigo Rivas Costa > > wrote: > > > There are two ways to connect the Steam Controller: directly to the USB > > > or with the USB wireless adapter. Both methods are similar, but the > > > wireless adapter can connect up to 4 devices at the same time. > > > > > > The wired device will appear as 3 interfaces: a virtual mouse, a virtual > > > keyboard and a custom HID device. > > > > > > The wireless device will appear as 5 interfaces: a virtual keyboard and > > > 4 custom HID devices, that will remain silent until a device is actually > > > connected. > > > > > > The custom HID device has a report descriptor with all vendor specific > > > usages, so the hid-generic is not very useful. In a PC/SteamBox Valve > > > Steam Client provices a software translation by using direct USB access > > > and a creates a uinput virtual gamepad. > > > > > > This driver was reverse engineered to provide direct kernel support in > > > case you cannot, or do not want to, use Valve Steam Client. It disables > > > the virtual keyboard and mouse, as they are not so useful when you have > > > a working gamepad. > > > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > +MODULE_LICENSE("GPL"); > > > > Not the same. > > Hmmm... I copied from usb-skeleton.c, IIRC... > I'll change to GPL-2.0+, that would be correct, I think. Yep, the usb-skeleton.c is wrong. I have prepared a patch, just not submitted it yet.. GPL-2.0+ is "GPLv2 or later" if that is what you want. Best regards Marcus Folkesson