From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v6 0/6] Add MediaTek PMIC keys support Date: Fri, 23 Mar 2018 11:54:18 -0700 Message-ID: <20180323185418.GD255819@dtor-ws> References: <1508937364-30054-1-git-send-email-chen.zhong@mediatek.com> <808b2029da224ab687fb0553cbc1c68e@mtkmbs08n1.mediatek.inc> <1521685073.28226.10.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1521685073.28226.10.camel@mtkswgap22> Sender: linux-kernel-owner@vger.kernel.org To: Sean Wang Cc: Rob Herring , Lee Jones , Alexandre Belloni , Mark Rutland , a.zummo@towertech.it, devicetree@vger.kernel.org, linus.walleij@linaro.org, jcsing.lee@samsung.com, linux-kernel@vger.kernel.org, krzk@kernel.org, javier@osg.samsung.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, matthias.bgg@gmail.com, eddie.huang@mediatek.com, Chen.Zhong@mediatek.com, beomho.seo@samsung.com, linux-rtc@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi Sean, On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote: > Hi, Dmitry and Lee > > The series seems not being got merged. Are they good enough to be ready > into the your tree? > > Recently I've tested the series with focusing on pwrkey event generated > through interrupt when push and release the key on bpi-r2 board and then > finally it's working fine. but for homekey it cannot be found on the > board and thus I cannot have more tests more about it. > > Tested-by: Sean Wang You have my Ack on the input patch; I expect it go through Lee's tree as there are some dependencies on mfd core piece. Thanks. > > Sean > > > On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote: > > > > > -----Original Message----- > > > From: Linux-mediatek [mailto:linux-mediatek-bounces@lists.infradead.org] On > > > Behalf Of Chen Zhong > > > Sent: Wednesday, October 25, 2017 9:16 PM > > > To: Dmitry Torokhov ; Rob Herring > > > ; Lee Jones ; Alexandre Belloni > > > > > > Cc: Mark Rutland ; Alessandro Zummo > > > ; devicetree@vger.kernel.org; Linus Walleij > > > ; Jaechul Lee ; linux- > > > kernel@vger.kernel.org; Krzysztof Kozlowski ; Javier > > > Martinez Canillas ; linux- > > > mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux- > > > input@vger.kernel.org; Matthias Brugger ; Eddie > > > Huang (S智) ; Chen Zhong (钟辰) > > > ; Beomho Seo ; > > > linux-rtc@vger.kernel.org > > > Subject: [PATCH v6 0/6] Add MediaTek PMIC keys support > > > > > > MediaTek PMIC are multi-function devices that can handle key interrupts, > > > typically there are two keys attached to PMIC, which called pwrkey and > > > homekey. PWRKEY usually used to wake up system from sleep. Homekey can > > > used as volume down key due to board design. Long press keys can shutdown > > > PMIC, the mode can be choose to be one key only or two keys together. > > > This series add support for key functions for MediaTek PMIC MT6397/MT6323. > > > > > > Changes since v5: > > > - use __maybe_unused annotation instead of #ifdef guard > > > - use of_* API instead of device_* API > > > > > > Changes since v4: > > > - rebase to Linux 4.14-rc1 > > > - add a common keyboard binding document > > > - use child device tree node to define each key > > > > > > Changes since v3: > > > - make the naming to be consistent as mtk_pmic or MTK_PMIC > > > - add suspend/resume functions to enable/disable irq > > > - change binding properties to define wakeup sources > > > > > > Changes since v2: > > > - use standard properties for keycodes and debounce time > > > - change to use platform_get_irq in leaf drivers > > > - use better ways to define IRQ resources > > > > > > Changes since v1: > > > - create irq mappings in mfd core driver instead of leaf drivers > > > - remove some unused parts in mtk-pmic-keys driver > > > > > > Chen Zhong (6): > > > mfd: mt6397: create irq mappings in mfd core driver > > > dt-bindings: input: Add common keyboard document bindings > > > dt-bindings: input: Add document bindings for mtk-pmic-keys > > > dt-bindings: mfd: Add bindings for the keys as subnode of PMIC > > > input: Add MediaTek PMIC keys support > > > mfd: mt6397: Add PMIC keys support to MT6397 driver > > > > > > Documentation/devicetree/bindings/input/keys.txt | 8 + > > > .../devicetree/bindings/input/mtk-pmic-keys.txt | 43 +++ > > > Documentation/devicetree/bindings/mfd/mt6397.txt | 6 + > > > drivers/input/keyboard/Kconfig | 9 + > > > drivers/input/keyboard/Makefile | 1 + > > > drivers/input/keyboard/mtk-pmic-keys.c | 339 > > > +++++++++++++++++++++ > > > drivers/mfd/mt6397-core.c | 26 +- > > > drivers/rtc/rtc-mt6397.c | 7 +- > > > 8 files changed, 432 insertions(+), 7 deletions(-) create mode 100644 > > > Documentation/devicetree/bindings/input/keys.txt > > > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic- > > > keys.txt > > > create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c > > > > > > -- > > > 1.9.1 > > > > > > > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > -- Dmitry