From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Rivas Costa Subject: Re: [PATCH v7 0/2] hid-steam driver with user mode client dection Date: Wed, 28 Mar 2018 23:44:38 +0200 Message-ID: <20180328214438.GA5740@casa> References: <20180325160703.15997-1-rodrigorivascosta@gmail.com> <20180328181448.GA1674@casa> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180328181448.GA1674@casa> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Tissoires Cc: "Pierre-Loup A. Griffais" , =?iso-8859-1?Q?Cl=E9ment?= VUCHENER , Jiri Kosina , Cameron Gutman , lkml , linux-input List-Id: linux-input@vger.kernel.org On Wed, Mar 28, 2018 at 08:14:48PM +0200, Rodrigo Rivas Costa wrote: > On Mon, Mar 26, 2018 at 10:12:19AM +0200, Benjamin Tissoires wrote: > > Also, I think there will be races if a user changes the value of the > > parameter while running the system. You might want to add an > > additional patch that would trigger the mode change on module > > parameter change. > > True, but the races should be easy to remove, with a simple local > variable. About the trigger, I've never seen a trigger on module > parameter change. Can you give me a hint or example of how to do that? Never mind, I've found it: module_param_cb(). Moreover, I'll have to keep a global list of steam_devices, just in case the parameter is changed... Regards. Rodrigo