From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Masaki Ota <masaki.ota@jp.alps.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: alps - Fix reporting pressure of v3 trackstick
Date: Mon, 23 Apr 2018 16:26:57 -0700 [thread overview]
Message-ID: <20180423232657.GH66646@dtor-ws> (raw)
In-Reply-To: <20180408155321.10433-1-pali.rohar@gmail.com>
On Sun, Apr 08, 2018 at 05:53:21PM +0200, Pali Rohár wrote:
> According to documentation, all 7 lower bits represents trackpoint pressure.
>
> Fixes: 4621c9660459 ("Input: alps - report pressure of v3 and v7 trackstick")
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Applied, thank you.
> ---
> drivers/input/mouse/alps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 0a9e6a3a2f9f..1e28d9fc5492 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -583,7 +583,7 @@ static void alps_process_trackstick_packet_v3(struct psmouse *psmouse)
>
> x = (s8)(((packet[0] & 0x20) << 2) | (packet[1] & 0x7f));
> y = (s8)(((packet[0] & 0x10) << 3) | (packet[2] & 0x7f));
> - z = packet[4] & 0x7c;
> + z = packet[4] & 0x7f;
>
> /*
> * The x and y values tend to be quite large, and when used
> --
> 2.11.0
>
--
Dmitry
prev parent reply other threads:[~2018-04-23 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 15:53 [PATCH] Input: alps - Fix reporting pressure of v3 trackstick Pali Rohár
2018-04-23 23:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423232657.GH66646@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).