[PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Oleksandr Andrushchenko]

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Add missing string constants for {feature|request}-raw-pointer
to align with the rest of the interface file.

Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 xen/include/public/io/kbdif.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
index 3ce54e9a44c1..daf4bc2063c9 100644
--- a/xen/include/public/io/kbdif.h
+++ b/xen/include/public/io/kbdif.h
@@ -178,8 +178,10 @@
 #define XENKBD_DRIVER_NAME             "vkbd"
 
 #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
+#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
 #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
 #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
+#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
 #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
 #define XENKBD_FIELD_RING_GREF         "page-gref"
 #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"
-- 
2.17.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Oleksandr Andrushchenko]

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

It is now not fully possible to control if and which virtual devices
are created by the frontend, e.g. keyboard and pointer devices
are always created and multi-touch device is created if the
backend advertises multi-touch support. In some cases this
behavior is not desirable and better control over the frontend's
configuration is required.

Add new XenStore feature fields, so it is possible to individually
control set of exposed virtual devices for each guest OS:
 - set feature-disable-keyboard to 1 if no keyboard device needs
   to be created
 - set feature-disable-pointer to 1 if no pointer device needs
   to be created

Keep old behavior by default.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/include/public/io/kbdif.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
index daf4bc2063c9..23d1f70d5210 100644
--- a/xen/include/public/io/kbdif.h
+++ b/xen/include/public/io/kbdif.h
@@ -51,6 +51,18 @@
  * corresponding entries in XenStore and puts 1 as the value of the entry.
  * If a feature is not supported then 0 must be set or feature entry omitted.
  *
+ * feature-disable-keyboard
+ *      Values:         <uint>
+ *
+ *      If there is no need to expose a virtual keyboard device by the
+ *      frontend then this must be set to 1.
+ *
+ * feature-disable-pointer
+ *      Values:         <uint>
+ *
+ *      If there is no need to expose a virtual pointer device by the
+ *      frontend then this must be set to 1.
+ *
  * feature-abs-pointer
  *      Values:         <uint>
  *
@@ -177,6 +189,8 @@
 
 #define XENKBD_DRIVER_NAME             "vkbd"
 
+#define XENKBD_FIELD_FEAT_DSBL_KEYBRD  "feature-disable-keyboard"
+#define XENKBD_FIELD_FEAT_DSBL_POINTER "feature-disable-pointer"
 #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
 #define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
 #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
-- 
2.17.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Oleksandr Andrushchenko]

Hi, Juergen!

This patch should go into 4.11 as it is needed for a related Linux
kernel patch and the risk is next to zero for Xen due to only adding
some macros not in use on Xen side.

Could you please release ack this and apply?

Thank you,
Oleksandr

On 05/02/2018 05:49 PM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> It is now not fully possible to control if and which virtual devices
> are created by the frontend, e.g. keyboard and pointer devices
> are always created and multi-touch device is created if the
> backend advertises multi-touch support. In some cases this
> behavior is not desirable and better control over the frontend's
> configuration is required.
>
> Add new XenStore feature fields, so it is possible to individually
> control set of exposed virtual devices for each guest OS:
>   - set feature-disable-keyboard to 1 if no keyboard device needs
>     to be created
>   - set feature-disable-pointer to 1 if no pointer device needs
>     to be created
>
> Keep old behavior by default.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>   xen/include/public/io/kbdif.h | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index daf4bc2063c9..23d1f70d5210 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -51,6 +51,18 @@
>    * corresponding entries in XenStore and puts 1 as the value of the entry.
>    * If a feature is not supported then 0 must be set or feature entry omitted.
>    *
> + * feature-disable-keyboard
> + *      Values:         <uint>
> + *
> + *      If there is no need to expose a virtual keyboard device by the
> + *      frontend then this must be set to 1.
> + *
> + * feature-disable-pointer
> + *      Values:         <uint>
> + *
> + *      If there is no need to expose a virtual pointer device by the
> + *      frontend then this must be set to 1.
> + *
>    * feature-abs-pointer
>    *      Values:         <uint>
>    *
> @@ -177,6 +189,8 @@
>   
>   #define XENKBD_DRIVER_NAME             "vkbd"
>   
> +#define XENKBD_FIELD_FEAT_DSBL_KEYBRD  "feature-disable-keyboard"
> +#define XENKBD_FIELD_FEAT_DSBL_POINTER "feature-disable-pointer"
>   #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
>   #define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
>   #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Juergen Gross]

On 17/05/18 07:45, Oleksandr Andrushchenko wrote:
> Hi, Juergen!
> 
> This patch should go into 4.11 as it is needed for a related Linux
> kernel patch and the risk is next to zero for Xen due to only adding
> some macros not in use on Xen side.
> 
> Could you please release ack this

Release-acked-by: Juergen Gross <jgross@suse.com>

> and apply?

This has to be done by a committer, which I'm not.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Oleksandr Andrushchenko]

On 05/17/2018 08:50 AM, Juergen Gross wrote:
> On 17/05/18 07:45, Oleksandr Andrushchenko wrote:
>> Hi, Juergen!
>>
>> This patch should go into 4.11 as it is needed for a related Linux
>> kernel patch and the risk is next to zero for Xen due to only adding
>> some macros not in use on Xen side.
>>
>> Could you please release ack this
> Release-acked-by: Juergen Gross <jgross@suse.com>
Thank you
>> and apply?
> This has to be done by a committer, which I'm not.
Konrad, could you please apply?
>
> Juergen
Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Konrad Rzeszutek Wilk]

On Thu, May 17, 2018 at 08:51:38AM +0300, Oleksandr Andrushchenko wrote:
> On 05/17/2018 08:50 AM, Juergen Gross wrote:
> > On 17/05/18 07:45, Oleksandr Andrushchenko wrote:
> > > Hi, Juergen!
> > > 
> > > This patch should go into 4.11 as it is needed for a related Linux
> > > kernel patch and the risk is next to zero for Xen due to only adding
> > > some macros not in use on Xen side.
> > > 
> > > Could you please release ack this
> > Release-acked-by: Juergen Gross <jgross@suse.com>
> Thank you
> > > and apply?
> > This has to be done by a committer, which I'm not.
> Konrad, could you please apply?

Yes of course.
> > 
> > Juergen
> Thank you,
> Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 2/2] xen/kbdif: Add features to disable keyboard and pointer

[Oleksandr Andrushchenko]

On 05/17/2018 05:09 PM, Konrad Rzeszutek Wilk wrote:
> On Thu, May 17, 2018 at 08:51:38AM +0300, Oleksandr Andrushchenko wrote:
>> On 05/17/2018 08:50 AM, Juergen Gross wrote:
>>> On 17/05/18 07:45, Oleksandr Andrushchenko wrote:
>>>> Hi, Juergen!
>>>>
>>>> This patch should go into 4.11 as it is needed for a related Linux
>>>> kernel patch and the risk is next to zero for Xen due to only adding
>>>> some macros not in use on Xen side.
>>>>
>>>> Could you please release ack this
>>> Release-acked-by: Juergen Gross <jgross@suse.com>
>> Thank you
>>>> and apply?
>>> This has to be done by a committer, which I'm not.
>> Konrad, could you please apply?
> Yes of course.
Thank you
>>> Juergen
>> Thank you,
>> Oleksandr


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Oleksandr Andrushchenko]

Konrad?

On 05/02/2018 05:49 PM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Add missing string constants for {feature|request}-raw-pointer
> to align with the rest of the interface file.
>
> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   xen/include/public/io/kbdif.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index 3ce54e9a44c1..daf4bc2063c9 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -178,8 +178,10 @@
>   #define XENKBD_DRIVER_NAME             "vkbd"
>   
>   #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
> +#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
>   #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
>   #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
> +#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
>   #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
>   #define XENKBD_FIELD_RING_GREF         "page-gref"
>   #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Konrad Rzeszutek Wilk]

On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Add missing string constants for {feature|request}-raw-pointer
> to align with the rest of the interface file.
> 
> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>


Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Thank you!
> ---
>  xen/include/public/io/kbdif.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index 3ce54e9a44c1..daf4bc2063c9 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -178,8 +178,10 @@
>  #define XENKBD_DRIVER_NAME             "vkbd"
>  
>  #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
> +#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
>  #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
>  #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
> +#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
>  #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
>  #define XENKBD_FIELD_RING_GREF         "page-gref"
>  #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"
> -- 
> 2.17.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Konrad Rzeszutek Wilk]

On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > Add missing string constants for {feature|request}-raw-pointer
> > to align with the rest of the interface file.
> > 
> > Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> 
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Juergen, you OK with an release-ack?

> 
> Thank you!
> > ---
> >  xen/include/public/io/kbdif.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> > index 3ce54e9a44c1..daf4bc2063c9 100644
> > --- a/xen/include/public/io/kbdif.h
> > +++ b/xen/include/public/io/kbdif.h
> > @@ -178,8 +178,10 @@
> >  #define XENKBD_DRIVER_NAME             "vkbd"
> >  
> >  #define XENKBD_FIELD_FEAT_ABS_POINTER  "feature-abs-pointer"
> > +#define XENKBD_FIELD_FEAT_RAW_POINTER  "feature-raw-pointer"
> >  #define XENKBD_FIELD_FEAT_MTOUCH       "feature-multi-touch"
> >  #define XENKBD_FIELD_REQ_ABS_POINTER   "request-abs-pointer"
> > +#define XENKBD_FIELD_REQ_RAW_POINTER   "request-raw-pointer"
> >  #define XENKBD_FIELD_REQ_MTOUCH        "request-multi-touch"
> >  #define XENKBD_FIELD_RING_GREF         "page-gref"
> >  #define XENKBD_FIELD_EVT_CHANNEL       "event-channel"
> > -- 
> > 2.17.0
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Juergen Gross]

On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Add missing string constants for {feature|request}-raw-pointer
>>> to align with the rest of the interface file.
>>>
>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Juergen, you OK with an release-ack?

Yes:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Oleksandr Andrushchenko]

On 05/11/2018 06:15 PM, Juergen Gross wrote:
> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>
>>>> Add missing string constants for {feature|request}-raw-pointer
>>>> to align with the rest of the interface file.
>>>>
>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and "request-raw-pointer")
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Juergen, you OK with an release-ack?
> Yes:
>
> Release-acked-by: Juergen Gross <jgross@suse.com>
Is this ack for both patches or this one only?
I see Konrad has applied this patch, but
"[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard 
and pointer"
is still floating.
>
> Juergen
Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Juergen Gross]

On 16/05/18 06:59, Oleksandr Andrushchenko wrote:
> On 05/11/2018 06:15 PM, Juergen Gross wrote:
>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko
>>>> wrote:
>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>
>>>>> Add missing string constants for {feature|request}-raw-pointer
>>>>> to align with the rest of the interface file.
>>>>>
>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and
>>>>> "request-raw-pointer")
>>>>>
>>>>> Signed-off-by: Oleksandr Andrushchenko
>>>>> <oleksandr_andrushchenko@epam.com>
>>>>
>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> Juergen, you OK with an release-ack?
>> Yes:
>>
>> Release-acked-by: Juergen Gross <jgross@suse.com>
> Is this ack for both patches or this one only?

It was meant for patch 1 only.

> I see Konrad has applied this patch, but
> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
> and pointer"
> is still floating.

In principle I'm fine with taking it for 4.11, but I think at this stage
of the release there should be a formal request to include it.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Oleksandr Andrushchenko]

On 05/17/2018 07:28 AM, Juergen Gross wrote:
> On 16/05/18 06:59, Oleksandr Andrushchenko wrote:
>> On 05/11/2018 06:15 PM, Juergen Gross wrote:
>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko
>>>>> wrote:
>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>>
>>>>>> Add missing string constants for {feature|request}-raw-pointer
>>>>>> to align with the rest of the interface file.
>>>>>>
>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and
>>>>>> "request-raw-pointer")
>>>>>>
>>>>>> Signed-off-by: Oleksandr Andrushchenko
>>>>>> <oleksandr_andrushchenko@epam.com>
>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>> Juergen, you OK with an release-ack?
>>> Yes:
>>>
>>> Release-acked-by: Juergen Gross <jgross@suse.com>
>> Is this ack for both patches or this one only?
> It was meant for patch 1 only.
Clear
>> I see Konrad has applied this patch, but
>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
>> and pointer"
>> is still floating.
> In principle I'm fine with taking it for 4.11, but I think at this stage
> of the release there should be a formal request to include it.
...and the request should come from Konrad?
Or who else may request that?

And, as I have r-b's from Konrad for both patches,
will it be ok if we apply the corresponding changes to the
kernel now, so my change to xen-kbdfront is unblocked?
>
> Juergen
Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Juergen Gross]

On 17/05/18 07:29, Oleksandr Andrushchenko wrote:
> On 05/17/2018 07:28 AM, Juergen Gross wrote:
>> On 16/05/18 06:59, Oleksandr Andrushchenko wrote:
>>> On 05/11/2018 06:15 PM, Juergen Gross wrote:
>>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko
>>>>>> wrote:
>>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>>>
>>>>>>> Add missing string constants for {feature|request}-raw-pointer
>>>>>>> to align with the rest of the interface file.
>>>>>>>
>>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and
>>>>>>> "request-raw-pointer")
>>>>>>>
>>>>>>> Signed-off-by: Oleksandr Andrushchenko
>>>>>>> <oleksandr_andrushchenko@epam.com>
>>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>> Juergen, you OK with an release-ack?
>>>> Yes:
>>>>
>>>> Release-acked-by: Juergen Gross <jgross@suse.com>
>>> Is this ack for both patches or this one only?
>> It was meant for patch 1 only.
> Clear
>>> I see Konrad has applied this patch, but
>>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
>>> and pointer"
>>> is still floating.
>> In principle I'm fine with taking it for 4.11, but I think at this stage
>> of the release there should be a formal request to include it.
> ...and the request should come from Konrad?
> Or who else may request that?

Normally the sender of the patch would make this request below the ---
of the commit message, e.g.:
  ---
  This patch should go into 4.11 as it is needed for a related Linux
  kernel patch and the risk is next to zero for Xen due to only adding
  some macros not in use on Xen side.

The request can be made by anyone, of course, e.g. by replying to the
patch mail and including the release manager as a recipient.

> And, as I have r-b's from Konrad for both patches,
> will it be ok if we apply the corresponding changes to the
> kernel now, so my change to xen-kbdfront is unblocked?

No, please don't do that.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v4 1/2] xen/kbdif: Add string constants for raw pointer

[Oleksandr Andrushchenko]

On 05/17/2018 08:42 AM, Juergen Gross wrote:
> On 17/05/18 07:29, Oleksandr Andrushchenko wrote:
>> On 05/17/2018 07:28 AM, Juergen Gross wrote:
>>> On 16/05/18 06:59, Oleksandr Andrushchenko wrote:
>>>> On 05/11/2018 06:15 PM, Juergen Gross wrote:
>>>>> On 11/05/18 15:38, Konrad Rzeszutek Wilk wrote:
>>>>>> On Fri, May 11, 2018 at 09:37:57AM -0400, Konrad Rzeszutek Wilk wrote:
>>>>>>> On Wed, May 02, 2018 at 05:49:18PM +0300, Oleksandr Andrushchenko
>>>>>>> wrote:
>>>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>>>>
>>>>>>>> Add missing string constants for {feature|request}-raw-pointer
>>>>>>>> to align with the rest of the interface file.
>>>>>>>>
>>>>>>>> Fixes 7868654ff7fe ("kbdif: Define "feature-raw-pointer" and
>>>>>>>> "request-raw-pointer")
>>>>>>>>
>>>>>>>> Signed-off-by: Oleksandr Andrushchenko
>>>>>>>> <oleksandr_andrushchenko@epam.com>
>>>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>>> Juergen, you OK with an release-ack?
>>>>> Yes:
>>>>>
>>>>> Release-acked-by: Juergen Gross <jgross@suse.com>
>>>> Is this ack for both patches or this one only?
>>> It was meant for patch 1 only.
>> Clear
>>>> I see Konrad has applied this patch, but
>>>> "[Xen-devel][PATCH v4 2/2] xen/kbdif: Add features to disable keyboard
>>>> and pointer"
>>>> is still floating.
>>> In principle I'm fine with taking it for 4.11, but I think at this stage
>>> of the release there should be a formal request to include it.
>> ...and the request should come from Konrad?
>> Or who else may request that?
> Normally the sender of the patch would make this request below the ---
> of the commit message, e.g.:
>    ---
>    This patch should go into 4.11 as it is needed for a related Linux
>    kernel patch and the risk is next to zero for Xen due to only adding
>    some macros not in use on Xen side.
>
> The request can be made by anyone, of course, e.g. by replying to the
> patch mail and including the release manager as a recipient.
Great, thank you
>> And, as I have r-b's from Konrad for both patches,
>> will it be ok if we apply the corresponding changes to the
>> kernel now, so my change to xen-kbdfront is unblocked?
> No, please don't do that.
Sure
>
> Juergen
Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel